Propagate name in more cases when using to_datetime
#21848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
commented
Jul 10, 2018
| @@ -250,8 +243,11 @@ def _convert_listlike_datetimes(arg, box, format, name=None, tz=None, | |||
| result, timezones = array_strptime( | |||
| arg, format, exact=exact, errors=errors) | |||
| if '%Z' in format or '%z' in format: | |||
| return _return_parsed_timezone_results( | |||
| result, timezones, box, tz) | |||
| tz_results = _return_parsed_timezone_results( | |||
|
#21703 is also proposed for this issue, though its currently failing. So happy to have you add tests. |
|
I was trying to stick to the convention in the file, but wanted is there a reason for local imports? Is that the convention in the codebase or is it OK to float the imports to the top? |
Codecov Report
@@ Coverage Diff @@
## master #21848 +/- ##
==========================================
+ Coverage 91.92% 91.92% +<.01%
==========================================
Files 160 160
Lines 49916 49917 +1
==========================================
+ Hits 45885 45886 +1
Misses 4031 4031
Continue to review full report at Codecov.
|
|
@eyurtsev you should not use local imports except in very specific circumstances |
jreback
requested changes
Jul 12, 2018
jreback
requested changes
Jul 20, 2018
4 tasks
|
closing as stale. would still take this PR if updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21697
Haven't ran tests yet