Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in roll_quantile #21966

Merged
merged 3 commits into from
Jul 19, 2018
Merged

Fix memory leak in roll_quantile #21966

merged 3 commits into from
Jul 19, 2018

Conversation

fl4p-old
Copy link
Contributor

closes #21965

@jreback
Copy link
Contributor

jreback commented Jul 18, 2018

looks reasonable, can you add a whatsnew note for 0.23.4 (bug fixes)

@jreback jreback added Bug Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jul 18, 2018
@codecov
Copy link

codecov bot commented Jul 18, 2018 •
edited
Loading

Codecov Report

Merging #21966 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21966   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         166      166           
  Lines       50329    50329           
=======================================
  Hits        46287    46287           
  Misses       4042     4042
Flag Coverage Δ
#multiple 90.36% <ø> (ø) ⬆️
#single 42.23% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 96.46% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce2473...13cca8e. Read the comment docs.

@fl4p-old
Copy link
Contributor Author

Sure, I just amended the commit

@jreback jreback added this to the 0.23.4 milestone Jul 19, 2018
@jreback jreback merged commit 27ebb3e into pandas-dev:master Jul 19, 2018
@jreback
Copy link
Contributor

jreback commented Jul 19, 2018

thanks @fl4p

lumberbot-app bot pushed a commit that referenced this pull request Jul 19, 2018
@fl4p-old
Backport PR #21966: Fix memory leak in roll_quantile
f2c611e
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 19, 2018
Merged
aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Jul 20, 2018
@fl4p-old @aeltanawy
Fix memory leak in roll_quantile (pandas-dev#21966)
405c57a
jreback pushed a commit that referenced this pull request Jul 20, 2018
@meeseeksmachine @jreback
Backport PR #21966: Fix memory leak in roll_quantile (#21973)
6a0a950
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@fl4p-old
Fix memory leak in roll_quantile (pandas-dev#21966)
07cd5cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
0.23.4
Development

Successfully merging this pull request may close these issues.

Memory Leak with rolling quantile
3 participants
@fl4p-old @jreback @fl4p