ENH: add np.nan* funcs to cython_table #22109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
add_np.nanfunc_to_cython_table
branch
3 times, most recently
from
e85a39d
to
449d912
Compare
3 tasks
topper-123
force-pushed
the
add_np.nanfunc_to_cython_table
branch
from
449d912
to
b12371d
Compare
Codecov Report
@@ Coverage Diff @@
## master #22109 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 169 169
Lines 51261 51261
=======================================
Hits 47277 47277
Misses 3984 3984
Continue to review full report at Codecov.
|
|
so couple of things on this. I don't the the additional functions are actually tested when run in pandas/tests/frame/test_apply.py. Its also very hard to see as the |
|
@topper-123 can you rebase |
|
can you rebase |
topper-123
force-pushed
the
add_np.nanfunc_to_cython_table
branch
from
b12371d
to
7080d24
Compare
|
Hello @topper-123! Thanks for updating the PR.
|
topper-123
force-pushed
the
add_np.nanfunc_to_cython_table
branch
from
7080d24
to
4dc9980
Compare
topper-123
force-pushed
the
add_np.nanfunc_to_cython_table
branch
from
4dc9980
to
51198ad
Compare
|
Rebased. Also, there were xfailed tests in |
|
thanks! |
thoo
added a commit
to thoo/pandas
that referenced
this pull request
Oct 30, 2018
…y_tests * repo_org/master: (52 commits) ENH: Allow rename_axis to specify index and columns arguments (pandas-dev#20046) STY: proposed isort settings [ci skip] [skip ci] [ciskip] [skipci] (pandas-dev#23366) MAINT: Remove extraneous test.parquet file CLN: Follow-up comments to pandas-devgh-23392 (pandas-dev#23401) BUG GH23282 calling min on series of NaT returns NaT (pandas-dev#23289) unpin openpyxl (pandas-dev#23361) REF: collect ops dispatch functions in one place, try to de-duplicate SparseDataFrame methods (pandas-dev#23060) CLN: Remove pandas.tools module (pandas-dev#23376) CLN: Remove some dtype methods from API (pandas-dev#23390) CLN: Cleanup toplevel namespace shims (pandas-dev#23386) DOC: fixup whatsnew note for GH21394 (pandas-dev#23355) Fix import format at pandas/tests/extension directory (pandas-dev#23365) DOC: Remove Series.sortlevel from api.rst (pandas-dev#23395) API: Disallow dtypes w/o frequency when casting (pandas-dev#23392) BUG/TST/REF: Datetimelike Arithmetic Methods (pandas-dev#23215) STYLE: lint add np.nan* funcs to cython_table (pandas-dev#22109) Run Isort on tests/util single PR (pandas-dev#23347) BUG: Fix date_range overflow (pandas-dev#23345) Run Isort on tests/arrays single PR (pandas-dev#23346) ...
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThis PR ensures that
Series.aggcan correctly take np.nan* funcs as inputs, e.g.:Previously that operation returned a Series. See #19629 for details.
Tests are added through the use of
_get_cython_table_paramsin the parametrisation oftest_agg_cython_tabletest function inseries/test_apply/frame/test_apply.