BUG: Better handling of invalid na_option argument for groupby.rank #22125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22125 +/- ##
==========================================
+ Coverage 92.07% 92.07% +<.01%
==========================================
Files 170 170
Lines 50694 50697 +3
==========================================
+ Hits 46674 46677 +3
Misses 4020 4020
Continue to review full report at Codecov.
|
jreback
added
Reshaping
jreback
requested changes
Jul 30, 2018
peterpanmj
force-pushed
the
na_option_handle
branch
from
ca106c3
to
9e83338
Compare
jreback
approved these changes
Jul 31, 2018
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -615,7 +615,7 @@ Reshaping | |||
| - Bug in :meth:`Series.combine_first` with ``datetime64[ns, tz]`` dtype which would return tz-naive result (:issue:`21469`) | |||
| - Bug in :meth:`Series.where` and :meth:`DataFrame.where` with ``datetime64[ns, tz]`` dtype (:issue:`21546`) | |||
| - Bug in :meth:`Series.mask` and :meth:`DataFrame.mask` with ``list`` conditionals (:issue:`21891`) | |||
| - | |||
| - :func: `pandas.core.groupby.GroupBy.rank` now raises a ValueError when an invalid value is passed for argument ``na_option`` (:issue:`22124`) | |||
There was a problem hiding this comment.
can you add double backticks on ValueError
doc/source/whatsnew/v0.24.0.txt
Outdated
| @@ -615,7 +615,7 @@ Reshaping | |||
| - Bug in :meth:`Series.combine_first` with ``datetime64[ns, tz]`` dtype which would return tz-naive result (:issue:`21469`) | |||
| - Bug in :meth:`Series.where` and :meth:`DataFrame.where` with ``datetime64[ns, tz]`` dtype (:issue:`21546`) | |||
| - Bug in :meth:`Series.mask` and :meth:`DataFrame.mask` with ``list`` conditionals (:issue:`21891`) | |||
| - | |||
| - :func: `pandas.core.groupby.GroupBy.rank` now raises a ValueError when an invalid value is passed for argument ``na_option`` (:issue:`22124`) | |||
peterpanmj
force-pushed
the
na_option_handle
branch
2 times, most recently
from
c1f4194
to
031be1d
Compare
peterpanmj
force-pushed
the
na_option_handle
branch
from
031be1d
to
8615d25
Compare
|
thanks! |
dberenbaum
pushed a commit
to dberenbaum/pandas
that referenced
this pull request
Aug 3, 2018
minggli
added a commit
to minggli/pandas
that referenced
this pull request
Aug 5, 2018
* master: (47 commits) Run tests in conda build [ci skip] (pandas-dev#22190) TST: Check DatetimeIndex.drop on DST boundary (pandas-dev#22165) CI: Fix Travis failures due to lint.sh on pandas/core/strings.py (pandas-dev#22184) Documentation: typo fixes in MultiIndex / Advanced Indexing (pandas-dev#22179) DOC: added .join to 'see also' in Series.str.cat (pandas-dev#22175) DOC: updated Series.str.contains see also section (pandas-dev#22176) 0.23.4 whatsnew (pandas-dev#22177) fix: scalar timestamp assignment (pandas-dev#19843) (pandas-dev#19973) BUG: Fix get dummies unicode error (pandas-dev#22131) Fixed py36-only syntax [ci skip] (pandas-dev#22167) DEPR: pd.read_table (pandas-dev#21954) DEPR: Removing previously deprecated datetools module (pandas-dev#6581) (pandas-dev#19119) BUG: Matplotlib scatter datetime (pandas-dev#22039) CLN: Use public method to capture UTC offsets (pandas-dev#22164) implement tslibs/src to make tslibs self-contained (pandas-dev#22152) Fix categorical from codes nan 21767 (pandas-dev#21775) BUG: Better handling of invalid na_option argument for groupby.rank(pandas-dev#22124) (pandas-dev#22125) use memoryviews instead of ndarrays (pandas-dev#22147) Remove depr. warning in SeriesGroupBy.count (pandas-dev#22155) API: Default to_* methods to compression='infer' (pandas-dev#22011) ...
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also related to #19499