dispatch scalar DataFrame ops to Series #22163
Many issues closed; will track them down and update. Will also need whatsnew.
This will be less verbose after #22068 implements
This still only dispatches a subset of ops. #22019 dispatches another (disjoint) subset. After that is another easy-ish case where alignment is known. Saved for last are cases with ambiguous alignment that is currently done in an ad-hoc best-guess way.
Re-opening after scaling back an unreasonably ambitious py2/py3 compat goal. In particular consider:
In PY3 ATM this gives:
And in PY2:
Making the PY2/PY3 behavior identical is not feasible, but we can (and this PR does) ensure that the DataFrame/Series behavior matches. In PY2 this is unchanged, in PY3 the DataFrame comparison now correctly raises.
@@ Coverage Diff @@ ## master #22163 +/- ## ========================================== - Coverage 92.08% 92.05% -0.04% ========================================== Files 169 169 Lines 50694 50700 +6 ========================================== - Hits 46682 46672 -10 - Misses 4012 4028 +16
referenced this pull request
Aug 7, 2018
jreback left a comment
i would like to have gh comments on the tests where appropriate. pls also do the whatsnew. its pretty important that we nail down and match the closed issues with the code.