Bump pytest

[WillAyd]

• closes Bump Min pytest Version #22319
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

@TomAugspurger

[jreback]

can you add a nice error message in the conftest.py that checks pytest version, else raises a nice error message? Ideally also add a test for this in test_downstream (though it should just pass as well always require this)

[codecov]

Codecov Report

Merging #22320 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22320   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         169      169           
  Lines       50709    50709           
=======================================
  Hits        46679    46679           
  Misses       4030     4030

Flag	Coverage Δ
#multiple	90.46% <ø> (ø)	⬆️
#single	42.25% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e6f7c...b26dacc. Read the comment docs.

[TomAugspurger]

There’s a way to do that directly with pytest. pytest_min_version of something like that.

…

________________________________ From: codecov[bot] <notifications@github.com> Sent: Monday, August 13, 2018 7:39:46 PM To: pandas-dev/pandas Cc: Tom Augspurger; Mention Subject: Re: [pandas-dev/pandas] Bump pytest (#22320) Codecov<https://codecov.io/gh/pandas-dev/pandas/pull/22320?src=pr&el=h1> Report Merging #22320<https://codecov.io/gh/pandas-dev/pandas/pull/22320?src=pr&el=desc> into master<https://codecov.io/gh/pandas-dev/pandas/commit/601d71fcfa9081fa88e5c20148972cd766396cd7?src=pr&el=desc> will not change coverage. The diff coverage is n/a. [Impacted file tree graph]<https://codecov.io/gh/pandas-dev/pandas/pull/22320?src=pr&el=tree> @@ Coverage Diff @@ ## master #22320 +/- ## ======================================= Coverage 92.08% 92.08% ======================================= Files 169 169 Lines 50706 50706 ======================================= Hits 46691 46691 Misses 4015 4015 Flag Coverage Δ #multiple 90.49% <ø> (ø) ⬆️ #single 42.33% <ø> (ø) ⬆️

________________________________ Continue to review full report at Codecov<https://codecov.io/gh/pandas-dev/pandas/pull/22320?src=pr&el=continue>. Legend - Click here to learn more<https://docs.codecov.io/docs/codecov-delta> Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov<https://codecov.io/gh/pandas-dev/pandas/pull/22320?src=pr&el=footer>. Last update 601d71f...68941b3<https://codecov.io/gh/pandas-dev/pandas/pull/22320?src=pr&el=lastupdated>. Read the comment docs<https://docs.codecov.io/docs/pull-request-comments>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22320 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIlFJifkCegXeRu4B_KLKqx2U2rddks5uQhxSgaJpZM4V7FbQ>.

[WillAyd]

Went with @TomAugspurger suggestion and updated the setup.cfg to require this, which gives a nice error message when trying to run below the required version:

ERROR: /Users/williamayd/clones/pandas/setup.cfg:34: requires pytest-3.6, actual pytest-3.4.1'

Not sure if there's a reasonable way to create a test for this so haven't done that, but @jreback if that's a deal breaker lmk and can explore options

[jreback]

can you add a whatsnew note (in Development, pls create if we don't have it). We put significant changes in the development process there. may need to edit slightly in contributing.rst as well.

This is actually user visible change as well. As users do pandas.test(), so may want to actually list in the dependencies changed (even though its not a strict dep).

and maybe add to install.rst as well (I don't think its listed), but for running tests it is required.

[jschendel]

Minor comment: The URL redirects me from doc.pytest to docs.pytest; would be nice to use the newer URL in case the redirect gets removed.

[jreback]

thanks!