BUG: Retain timezone information in to_datetime if box=False #22457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you just append this issue number to the prior whatsnew entry, otherwise lgtm (failing tests though) |
Codecov Report
@@ Coverage Diff @@
## master #22457 +/- ##
==========================================
- Coverage 92.05% 92.04% -0.01%
==========================================
Files 169 169
Lines 50733 50743 +10
==========================================
+ Hits 46702 46708 +6
- Misses 4031 4035 +4
Continue to review full report at Codecov.
|
jreback
approved these changes
Aug 23, 2018
| return DatetimeIndex._simple_new(result, name=name, | ||
| tz=tz_parsed) | ||
| if tz_parsed is not None: | ||
| if box: |
There was a problem hiding this comment.
can you add some comments here would be great (just to make it easier to read, the block below as well)
|
Thanks @jreback. (Build errors were unrelated to the last commit) |
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
…dev#22457) * BUG: Retain timezone information in to_datetime if box=False * fix test and add issue number to whatsnew * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffDon't think this requires a whatsnew entry since this was introduced in (and part of) #21822 which is slated for v0.24.0