Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix (22477) dtype=str converts NaN to 'n' #22564

Merged
merged 19 commits into from Nov 20, 2018

Commits on Nov 11, 2018

  1. tests for creating series string dtype

    More specifically the cases that seem to have an issue
    are when:
    - the series in empty
    - it's a single element series
    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    f069fc2 View commit details
    Browse the repository at this point in the history
  2. Closes pandas-dev#22477

    Add a check so if the dtype is str is will create
    an empty array type object and then pass the values.
    
    Add test for an empty series. To chech that it fills the series
    with NaN and not with 'n'.
    
    Also add a test for cases that no string values are given.
    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    062786f View commit details
    Browse the repository at this point in the history
  3. undo changes to series.py

    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    a522d7f View commit details
    Browse the repository at this point in the history
  4. comment issue number under test

    To allow the developers to remember why the specific test was added
    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    c8667dd View commit details
    Browse the repository at this point in the history
  5. add test for strings

    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    4717e36 View commit details
    Browse the repository at this point in the history
  6. add test for unicode elements: fails

    This is currently failing.
    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    bdad724 View commit details
    Browse the repository at this point in the history
  7. except unicode in is_datetime64_dtype

    is_datetime64_dtype is trying to check the type
    of unicodes but numpy does not support unicode and
    this line breaks.
    
    Add except error and return false
    Test for unicode still fails for python 2
    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    7691c82 View commit details
    Browse the repository at this point in the history
  8. series with dtype accept unicode

    This was breaking for python 2.
    The fix is to use pandas text_type to return string type
    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    00a7ed8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e9a290d View commit details
    Browse the repository at this point in the history
  10. tweak tests as requested on pr

    parametrize tests and use iloc to check value
    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    aa6b4a9 View commit details
    Browse the repository at this point in the history
  11. style tweak

    Nikoleta-v3 committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    ee854d7 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2018

  1. Configuration menu
    Copy the full SHA
    64f6e1c View commit details
    Browse the repository at this point in the history
  2. fixup

    jreback committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    fdad0c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    31021b6 View commit details
    Browse the repository at this point in the history
  4. fix test

    jreback committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    9711d35 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. Configuration menu
    Copy the full SHA
    086d2b5 View commit details
    Browse the repository at this point in the history
  2. fixup

    jreback committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    27701e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    265f92d View commit details
    Browse the repository at this point in the history
  4. fixup

    jreback committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    0692db0 View commit details
    Browse the repository at this point in the history