New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix (22477) dtype=str converts NaN to 'n' #22564
Merged
jorisvandenbossche
merged 19 commits into
pandas-dev:master
from
Nikoleta-v3:fix_issue_22477
Nov 20, 2018
Merged
BUG: Fix (22477) dtype=str converts NaN to 'n' #22564
jorisvandenbossche
merged 19 commits into
pandas-dev:master
from
Nikoleta-v3:fix_issue_22477
Nov 20, 2018
Commits on Nov 11, 2018
-
tests for creating series string dtype
More specifically the cases that seem to have an issue are when: - the series in empty - it's a single element series
Configuration menu - View commit details
-
Copy full SHA for f069fc2 - Browse repository at this point
Copy the full SHA f069fc2View commit details -
Add a check so if the dtype is str is will create an empty array type object and then pass the values. Add test for an empty series. To chech that it fills the series with NaN and not with 'n'. Also add a test for cases that no string values are given.
Configuration menu - View commit details
-
Copy full SHA for 062786f - Browse repository at this point
Copy the full SHA 062786fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a522d7f - Browse repository at this point
Copy the full SHA a522d7fView commit details -
comment issue number under test
To allow the developers to remember why the specific test was added
Configuration menu - View commit details
-
Copy full SHA for c8667dd - Browse repository at this point
Copy the full SHA c8667ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4717e36 - Browse repository at this point
Copy the full SHA 4717e36View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdad724 - Browse repository at this point
Copy the full SHA bdad724View commit details -
except unicode in is_datetime64_dtype
is_datetime64_dtype is trying to check the type of unicodes but numpy does not support unicode and this line breaks. Add except error and return false Test for unicode still fails for python 2
Configuration menu - View commit details
-
Copy full SHA for 7691c82 - Browse repository at this point
Copy the full SHA 7691c82View commit details -
series with dtype accept unicode
This was breaking for python 2. The fix is to use pandas text_type to return string type
Configuration menu - View commit details
-
Copy full SHA for 00a7ed8 - Browse repository at this point
Copy the full SHA 00a7ed8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9a290d - Browse repository at this point
Copy the full SHA e9a290dView commit details -
tweak tests as requested on pr
parametrize tests and use iloc to check value
Configuration menu - View commit details
-
Copy full SHA for aa6b4a9 - Browse repository at this point
Copy the full SHA aa6b4a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee854d7 - Browse repository at this point
Copy the full SHA ee854d7View commit details
Commits on Nov 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 64f6e1c - Browse repository at this point
Copy the full SHA 64f6e1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdad0c5 - Browse repository at this point
Copy the full SHA fdad0c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31021b6 - Browse repository at this point
Copy the full SHA 31021b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9711d35 - Browse repository at this point
Copy the full SHA 9711d35View commit details
Commits on Nov 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 086d2b5 - Browse repository at this point
Copy the full SHA 086d2b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27701e0 - Browse repository at this point
Copy the full SHA 27701e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 265f92d - Browse repository at this point
Copy the full SHA 265f92dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0692db0 - Browse repository at this point
Copy the full SHA 0692db0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.