Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Rename 'n' to 'repeats' in .repeat methods #22574

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Sep 2, 2018

For Index and MultiIndex.

xref #14645.

@gfyoung gfyoung added Deprecate Functionality to remove in pandas Clean labels Sep 2, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Sep 2, 2018
@codecov
Copy link

codecov bot commented Sep 2, 2018

Codecov Report

Merging #22574 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22574   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50787    50787           
=======================================
  Hits        46745    46745           
  Misses       4042     4042
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 42.29% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.45% <ø> (ø) ⬆️
pandas/core/indexes/multi.py 95.41% <100%> (ø) ⬆️
pandas/core/strings.py 98.63% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550a5ca...780019d. Read the comment docs.

@@ -527,6 +527,7 @@ Removal of prior version deprecations/changes
- Several private functions were removed from the (non-public) module ``pandas.core.common`` (:issue:`22001`)
- Removal of the previously deprecated module ``pandas.core.datetools`` (:issue:`14105`, :issue:`14094`)
- Strings passed into :meth:`DataFrame.groupby` that refer to both column and index levels will raise a ``ValueError`` (:issue:`14432`)
- :meth:`Index.repeat` and :meth:`MultiIndex.repeat` have renamed the ``n`` argument to ``repeats``(:issue:`14645`)
-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n is being removed though, not renamed? Maybe

:meth:Index.repeat and :meth:MultiIndex.repeat have the n synonym to the repeats argument removed (deprecated since v.0.20.0) ). (:issue:14645)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original argument was n. Then we deprecated in favor of repeats. Now we're permanently renaming it to repeats. That's why it's described as such.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I see it is that in 0.20 n was renamed and deprecated, and now the deprecated param n is being removed...

Anyway, could just be a difference of perspective.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, could just be a difference of perspective.

Agreed.

@jreback jreback merged commit 9e362a6 into pandas-dev:master Sep 4, 2018
@jreback
Copy link
Contributor

jreback commented Sep 4, 2018

thanks!

@gfyoung gfyoung deleted the repeat-n-reps branch September 5, 2018 03:53
aeltanawy pushed a commit to aeltanawy/pandas that referenced this pull request Sep 20, 2018
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants