New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: GroupBy return EA dtype #23318
Merged
Merged
BUG: GroupBy return EA dtype #23318
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
09e8472
Added EA check and passed through _from_sequence
5hirish 27ce828
Added test case to check extension arrays dtype
5hirish 28b45f2
BUG: GH23227 Fixed
5hirish 9243612
Fixed arrays tests to check dtypes
5hirish 9502ba4
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
5hirish 14666a1
Fixed sparse test cases
5hirish 44287de
Fixed test case to re-sample categorical data for timedelta
5hirish d54c743
test case dataframe assertion added
5hirish 05eb70c
Added whatsnew in v0.24.0
5hirish 8ac749d
Merge remote-tracking branch 'upstream/master' into 5hirish-bug_agg_e…
TomAugspurger c1d8416
Fixed isort
TomAugspurger fc5d2f2
Updated whatsnew for 0.24.0
5hirish 2859c70
Updated whatsnew for 0.24.0, applied suggestions to sparse/test_group
5hirish 07ffcc7
Updated whatsnew for 0.24.0, applied suggestions to sparse/test_group…
5hirish 2487fd1
Applied suggestions to sparse/test_groupby
5hirish File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fully construct the return frame as in the existing example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean this
a)
b) or do you mean that I should construct the expected as:
Because in b) the expected constructed dataframe converts
Int64
toint64
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Int64" (capital "I") is a pandas thing. You need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 2nd. we want to construct the resulting frame and compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this marked resolved? Am I missing the
expected
and thetm.assert_frame_equal
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, you are correct, I missed that one...