Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Test unnamed columns with index_col for Excel #23874

Merged
merged 2 commits into from
Nov 28, 2018
Merged

TST: Test unnamed columns with index_col for Excel #23874

merged 2 commits into from
Nov 28, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 23, 2018

Closes #18792.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel labels Nov 23, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 23, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

WillAyd
WillAyd approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@jreback
Copy link
Contributor

jreback commented Nov 23, 2018

failing on py2

@gfyoung
Copy link
Member Author

gfyoung commented Nov 23, 2018 •
edited
Loading

failing on py2

If I made this PR in January, this wouldn't be a problem 😉 . Debugging right now.

Also, looks like this issue was patched when I fixed #20480.

@codecov
Copy link

codecov bot commented Nov 23, 2018 •
edited
Loading

Codecov Report

Merging #23874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23874   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         161      161           
  Lines       51471    51471           
=======================================
  Hits        47515    47515           
  Misses       3956     3956
Flag Coverage Δ
#multiple 90.7% <ø> (ø) ⬆️
#single 42.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca70fe6...7861850. Read the comment docs.

@gfyoung
Copy link
Member Author

gfyoung commented Nov 23, 2018

Alright, got everything green now! PTAL.

@gfyoung gfyoung force-pushed the excel-index-col-test branch 3 times, most recently from 091dbe6 to 418bc65 Compare November 28, 2018 05:46
@gfyoung
Copy link
Member Author

gfyoung commented Nov 28, 2018

@jreback: Patched the 2.x bug, and all is green. PTAL.

@jreback jreback merged commit adc47d8 into pandas-dev:master Nov 28, 2018
@jreback
Copy link
Contributor

jreback commented Nov 28, 2018

thanks @gfyoung

@gfyoung gfyoung deleted the excel-index-col-test branch November 28, 2018 22:58
@WillAyd WillAyd mentioned this pull request Feb 12, 2019
Closed
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
TST: Test unnamed columns with index_col for Excel (pandas-dev#23874)
8992b3b
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
TST: Test unnamed columns with index_col for Excel (pandas-dev#23874)
46044a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gfyoung @pep8speaks @jreback @WillAyd