Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Test unnamed columns with index_col for Excel #23874

Merged
merged 2 commits into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@gfyoung
Copy link
Member

commented Nov 23, 2018

Closes #18792.

@gfyoung gfyoung added this to the 0.24.0 milestone Nov 23, 2018

@pep8speaks

This comment has been minimized.

Copy link

commented Nov 23, 2018

Hello @gfyoung! Thanks for submitting the PR.

@WillAyd
Copy link
Member

left a comment

lgtm - thanks!

@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2018

failing on py2

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2018

failing on py2

If I made this PR in January, this wouldn't be a problem 😉 . Debugging right now.

Also, looks like this issue was patched when I fixed #20480.

@gfyoung gfyoung force-pushed the forking-repos:excel-index-col-test branch from 6245b59 to 26729ba Nov 23, 2018

@codecov

This comment has been minimized.

Copy link

commented Nov 23, 2018

Codecov Report

Merging #23874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23874   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         161      161           
  Lines       51471    51471           
=======================================
  Hits        47515    47515           
  Misses       3956     3956
Flag Coverage Δ
#multiple 90.7% <ø> (ø) ⬆️
#single 42.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca70fe6...7861850. Read the comment docs.

@gfyoung gfyoung force-pushed the forking-repos:excel-index-col-test branch from 26729ba to f622d45 Nov 23, 2018

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2018

Alright, got everything green now! PTAL.

Show resolved Hide resolved pandas/tests/io/test_excel.py Outdated

@gfyoung gfyoung force-pushed the forking-repos:excel-index-col-test branch 3 times, most recently from 091dbe6 to 418bc65 Nov 25, 2018

gfyoung added some commits Nov 23, 2018

@gfyoung gfyoung force-pushed the forking-repos:excel-index-col-test branch from 418bc65 to 7861850 Nov 28, 2018

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

@jreback: Patched the 2.x bug, and all is green. PTAL.

@jreback jreback merged commit adc47d8 into pandas-dev:master Nov 28, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20181128.29 succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2018

thanks @gfyoung

@gfyoung gfyoung deleted the forking-repos:excel-index-col-test branch Nov 28, 2018

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.