Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecating .clip_lower and .clip_upper #24203

Merged

Conversation

Projects
None yet
4 participants
@datapythonista
Copy link
Member

commented Dec 10, 2018

  • xref #18262
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@pep8speaks

This comment has been minimized.

Copy link

commented Dec 10, 2018

Hello @datapythonista! Thanks for submitting the PR.

@jreback jreback referenced this pull request Dec 10, 2018

Open

DEPR: let's deprecate #18262

22 of 35 tasks complete
@codecov

This comment has been minimized.

Copy link

commented Dec 10, 2018

Codecov Report

Merging #24203 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24203      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files         162      162              
  Lines       51723    51725       +2     
==========================================
+ Hits        47695    47696       +1     
- Misses       4028     4029       +1
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 43.03% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 96.65% <100%> (ø) ⬆️
pandas/io/json/json.py 92.61% <0%> (-0.48%) ⬇️
pandas/util/testing.py 87.51% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138a59a...5d0d01a. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Dec 10, 2018

Codecov Report

Merging #24203 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24203      +/-   ##
==========================================
+ Coverage   92.21%   92.21%   +<.01%     
==========================================
  Files         162      162              
  Lines       51761    51763       +2     
==========================================
+ Hits        47731    47733       +2     
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 43% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 96.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5389987...383f6d6. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 10, 2018

@jreback
Copy link
Contributor

left a comment

looks fine. one small comment. pls add to #6581 as well

@@ -1113,6 +1113,8 @@ Deprecations
- :func:`pandas.types.is_datetimetz` is deprecated in favor of `pandas.types.is_datetime64tz` (:issue:`23917`)
- Creating a :class:`TimedeltaIndex` or :class:`DatetimeIndex` by passing range arguments `start`, `end`, and `periods` is deprecated in favor of :func:`timedelta_range` and :func:`date_range` (:issue:`23919`)
- Passing a string alias like ``'datetime64[ns, UTC]'`` as the `unit` parameter to :class:`DatetimeTZDtype` is deprecated. Use :class:`DatetimeTZDtype.construct_from_string` instead (:issue:`23990`).
- :meth:`Series.clip_lower`, :meth:`Series.clip_upper`, :meth:`DataFrame.clip_lower` and :meth:`DataFrame.clip_upper` are deprecated and will be removed in a future version.
Use ``Series.clip(lower=threshold)``, ``Series.clip(upper=threshold)`` and the equivalent ``DataFrame`` methods (:issue:`24203`)

This comment has been minimized.

Copy link
@jreback

jreback Dec 10, 2018

Contributor

is this on another line?

@jreback

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2018

and pls merge master

datapythonista added some commits Dec 10, 2018

@jsexauer jsexauer referenced this pull request Dec 10, 2018

Open

DEPR: deprecations from prior versions #6581

0 of 94 tasks complete
@jreback

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2018

lgtm. merge on green.

@datapythonista datapythonista merged commit a771b47 into pandas-dev:master Dec 10, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20181210.49 succeeded
Details

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.