Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Splitting api.rst in several files #24462

Merged
merged 5 commits into from
Dec 30, 2018
Merged

DOC: Splitting api.rst in several files #24462

merged 5 commits into from
Dec 30, 2018

Conversation

datapythonista
Copy link
Member

@datapythonista datapythonista commented Dec 28, 2018

@TomAugspurger do you know why moving the api autosummary to a directory, make the build not find the generated files? For what I understand, the :toctree: generated/ is used for both, to know where to generate the API files, and later on to link them. But it looks like they are generated in generated/, but then I get warnings because sphinx is looking for them in api/generated/.

There was something a bit tricky in the autosummary_generate option that I removed in #24428 (it's not yet merged), but I don't see anything in the configuration that can be causing this behavior (and I've seen other projects using autosummaries in directories without problems, like https://github.com/bradgwest/esof523a3/tree/master/doc/reference).

@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #24462 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24462      +/-   ##
==========================================
- Coverage    92.3%   92.29%   -0.01%     
==========================================
  Files         163      163              
  Lines       51969    51969              
==========================================
- Hits        47968    47967       -1     
- Misses       4001     4002       +1
Flag Coverage Δ
#multiple 90.7% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1549f...fc99580. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #24462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24462   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         166      166           
  Lines       52412    52412           
=======================================
  Hits        48382    48382           
  Misses       4030     4030
Flag Coverage Δ
#multiple 90.73% <ø> (ø) ⬆️
#single 43.05% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e5bf7...eba3985. Read the comment docs.

@TomAugspurger
Copy link
Contributor

I'm not sure what would be wrong with the autosummary. Your description sounds correct.

@datapythonista datapythonista changed the title DOC: Splitting api.rst in several files WIP/DOC: Splitting api.rst in several files Dec 29, 2018
@datapythonista
Copy link
Member Author

@TomAugspurger looks like the problem with the paths is indeed caused by setting the list of .rst in the top doc/source directory to autosummary_generate. That's addressed in #24428, which should be ready now. This will work once that one is merged.

@datapythonista datapythonista changed the title WIP/DOC: Splitting api.rst in several files DOC: Splitting api.rst in several files Dec 30, 2018
@datapythonista
Copy link
Member Author

This is looking good now, I think it can be merged. In this PR I just did the splitting without making any other change (more than standardizing blank lines, and the currentmodule directive).

A small change to the validation script was needed to keep it working, which is implemented here (at the very end of the changes).

In a follow up I'll propose changes to the titles of some pages, but I don't want to implement them here, as this is difficult to review, and I think it's better to not change any content here.

There are some warnings, but none is introduced here, I'll keep taking care of them in separate PRs.

This is how the new API main page looks like:

api_home

And this is a sample of one of the individual pages:

api_io

CC: @TomAugspurger @jreback

@TomAugspurger
Copy link
Contributor

LGTM. Maybe wait till later today to merge in case other's have comments.

We might want to rethink some of the organization / section headings (e.g. "general functions" isn't especially informative) but those can be done as followups.

@jreback jreback added this to the 0.24.0 milestone Dec 30, 2018
@jreback
Copy link
Contributor

jreback commented Dec 30, 2018

yeah this is ok. sure we need some work on the names / maybe some org of this, but a great first step.

@jreback jreback merged commit 0efbbc2 into pandas-dev:master Dec 30, 2018
thoo added a commit to thoo/pandas that referenced this pull request Dec 30, 2018
* upstream/master:
  DOC: Fixing broken references in the docs (pandas-dev#24497)
  DOC: Splitting api.rst in several files (pandas-dev#24462)
  Fix misdescription in escapechar (pandas-dev#24490)
  Floor and ceil methods during pandas.eval which are provided by numexpr (pandas-dev#24355)
  BUG: Pandas any() returning false with true values present (GH pandas-dev#23070) (pandas-dev#24434)
  Misc separable pieces of pandas-dev#24024 (pandas-dev#24488)
  use capsys.readouterr() as named tuple (pandas-dev#24489)
  REF/TST: replace capture_stderr with pytest capsys fixture (pandas-dev#24496)
  TST- Fixing issue with test_parquet test unexpectedly passing (pandas-dev#24480)
  DOC: Doc build for a single doc made much faster, and clean up (pandas-dev#24428)
  BUG: Fix+test timezone-preservation in DTA.repeat (pandas-dev#24483)
  Implement reductions from pandas-dev#24024 (pandas-dev#24484)
thoo added a commit to thoo/pandas that referenced this pull request Dec 30, 2018
…strings

* upstream/master:
  TST: Skip db tests unless explicitly specified in -m pattern (pandas-dev#24492)
  Mix EA into DTA/TDA; part of 24024 (pandas-dev#24502)
  DOC: Fix building of a single API document (pandas-dev#24506)
  DOC: Fixing broken references in the docs (pandas-dev#24497)
  DOC: Splitting api.rst in several files (pandas-dev#24462)
  Fix misdescription in escapechar (pandas-dev#24490)
  Floor and ceil methods during pandas.eval which are provided by numexpr (pandas-dev#24355)
  BUG: Pandas any() returning false with true values present (GH pandas-dev#23070) (pandas-dev#24434)
  Misc separable pieces of pandas-dev#24024 (pandas-dev#24488)
  use capsys.readouterr() as named tuple (pandas-dev#24489)
  REF/TST: replace capture_stderr with pytest capsys fixture (pandas-dev#24496)
  TST- Fixing issue with test_parquet test unexpectedly passing (pandas-dev#24480)
  DOC: Doc build for a single doc made much faster, and clean up (pandas-dev#24428)
  BUG: Fix+test timezone-preservation in DTA.repeat (pandas-dev#24483)
  Implement reductions from pandas-dev#24024 (pandas-dev#24484)
gfyoung pushed a commit that referenced this pull request Dec 31, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Split api.rst in sections
3 participants