Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix interpreting int as second--> nano #24694

Merged
merged 5 commits into from Jan 10, 2019
Merged

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 10, 2019

The existing behavior was put in place in #4684, looks like wrestling with numpy 1.6 and 1.7 was rough.

Not sure what this merits in the whatsnew, pls advise.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@jbrockmendel
Copy link
Member Author

@jbrockmendel jbrockmendel commented Jan 10, 2019

Travis fail is hypothesis

pandas/core/internals/blocks.py Show resolved Hide resolved
@jbrockmendel
Copy link
Member Author

@jbrockmendel jbrockmendel commented Jan 10, 2019

Closes #19233

@codecov
Copy link

@codecov codecov bot commented Jan 10, 2019

Codecov Report

Merging #24694 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24694      +/-   ##
==========================================
+ Coverage   43.06%   43.06%   +<.01%     
==========================================
  Files         166      166              
  Lines       52310    52310              
==========================================
+ Hits        22526    22529       +3     
+ Misses      29784    29781       -3
Flag Coverage Δ
#single 43.06% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 52.71% <0%> (ø) ⬆️
pandas/util/testing.py 50.73% <0%> (-0.93%) ⬇️
pandas/io/json/json.py 62.85% <0%> (+1.19%) ⬆️
pandas/core/internals/construction.py 64.21% <0%> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021cbae...f059530. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Jan 10, 2019

Codecov Report

Merging #24694 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24694      +/-   ##
==========================================
+ Coverage   92.38%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52310    52311       +1     
==========================================
+ Hits        48327    48328       +1     
  Misses       3983     3983
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43.06% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 94.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021cbae...e9cb0ab. Read the comment docs.

@jbrockmendel
Copy link
Member Author

@jbrockmendel jbrockmendel commented Jan 10, 2019

Reverted change, made a deprecation instead.

@jreback
Copy link
Contributor

@jreback jreback commented Jan 10, 2019

lgtm. ping on green.

@jreback jreback merged commit bad02e8 into pandas-dev:master Jan 10, 2019
2 checks passed
@jbrockmendel jbrockmendel deleted the tdfill branch Jan 10, 2019
Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this issue Feb 28, 2019
Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this issue Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants