Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #24961 on branch 0.24.x (fix+test to_timedelta('NaT', box=False)) #25025

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Backport PR #24961 on branch 0.24.x (fix+test to_timedelta('NaT', box=False)) #25025

merged 1 commit into from
Jan 30, 2019

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #24961: fix+test to_timedelta('NaT', box=False)

@lumberbot-app lumberbot-app bot added this to the 0.24.1 milestone Jan 30, 2019
@jreback jreback added Regression Functionality that used to work in a prior pandas version Timedelta Timedelta data type labels Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #25025 into 0.24.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.24.x   #25025   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52391    52391           
=======================================
  Hits        48399    48399           
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 42.89% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/tools/timedeltas.py 98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54c3a5...6adb3f8. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #25025 into 0.24.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.24.x   #25025   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52391    52391           
=======================================
  Hits        48399    48399           
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 42.89% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/tools/timedeltas.py 98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54c3a5...6adb3f8. Read the comment docs.

@jreback jreback merged commit c228597 into pandas-dev:0.24.x Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Regression Functionality that used to work in a prior pandas version Timedelta Timedelta data type
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meeseeksmachine @jreback @jbrockmendel