BUG: Series.__setitem__ with datetimetz data #25331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Bug
Indexing
gfyoung
reviewed
Feb 15, 2019
|
|
||
| def test_setitem_str_with_datetimetz(): | ||
| # GH 12862 | ||
| result = pd.Series() |
There was a problem hiding this comment.
nit: use Series directly instead of pd.Series (you do so in your first test)
jreback
requested changes
Feb 16, 2019
| @@ -1047,7 +1047,11 @@ def setitem(key, value): | |||
| self._maybe_update_cacher() | |||
|
|
|||
| def _set_with_engine(self, key, value): | |||
| values = self._values | |||
| if is_extension_array_dtype(self): | |||
| # GH 20441: set_value expects and ndarray, not ExtensionArray | |||
There was a problem hiding this comment.
and -> an, but can't we just do: .to_numpy() ?
|
Going to postpone this. The fix is more complicated than I originally thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff