Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Set pytest minversion to 4.0.2 #25402

Merged
merged 8 commits into from
Feb 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/deps/azure-27-compat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies:
- xlsxwriter=0.5.2
- xlwt=0.7.5
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- isort
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-27-locale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ dependencies:
- xlsxwriter=0.5.2
- xlwt=0.7.5
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-36-locale_slow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dependencies:
- xlsxwriter
- xlwt
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- moto
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-37-locale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies:
- xlsxwriter
- xlwt
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- isort
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-37-numpydev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- pytz
- Cython>=0.28.2
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- hypothesis>=3.58.0
Expand Down
8 changes: 4 additions & 4 deletions ci/deps/azure-macos-35.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ dependencies:
- xlrd
- xlsxwriter
- xlwt
# universal
- pytest
- pytest-xdist
- pytest-mock
- isort
- pip:
- python-dateutil==2.5.3
# universal
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- hypothesis>=3.58.0
2 changes: 1 addition & 1 deletion ci/deps/azure-windows-27.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies:
- xlwt
# universal
- cython>=0.28.2
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- moto
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/azure-windows-36.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ dependencies:
- xlwt
# universal
- cython>=0.28.2
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-27.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ dependencies:
- xlsxwriter=0.5.2
- xlwt=0.7.5
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- moto==1.3.4
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36-doc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ dependencies:
- xlsxwriter
- xlwt
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- isort
2 changes: 1 addition & 1 deletion ci/deps/travis-36-locale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ dependencies:
- xlsxwriter
- xlwt
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- moto
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36-slow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies:
- xlsxwriter
- xlwt
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- moto
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-36.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies:
- xlsxwriter
- xlwt
# universal
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-cov
- pytest-mock
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/travis-37.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies:
- nomkl
- pyarrow
- pytz
- pytest
- pytest>=4.0.2
- pytest-xdist
- pytest-mock
- hypothesis>=3.58.0
Expand Down
2 changes: 1 addition & 1 deletion doc/source/development/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ extensions in `numpy.testing

.. note::

The earliest supported pytest version is 3.6.0.
The earliest supported pytest version is 4.0.2.

Writing tests
~~~~~~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion doc/source/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ pandas is equipped with an exhaustive set of unit tests, covering about 97% of
the code base as of this writing. To run it on your machine to verify that
everything is working (and that you have all of the dependencies, soft and hard,
installed), make sure you have `pytest
<http://docs.pytest.org/en/latest/>`__ >= 3.6 and `Hypothesis
<http://docs.pytest.org/en/latest/>`__ >= 4.0.2 and `Hypothesis
<https://hypothesis.readthedocs.io/>`__ >= 3.58, then run:

::
Expand Down
14 changes: 14 additions & 0 deletions doc/source/whatsnew/v0.25.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,20 @@ is respected in indexing. (:issue:`24076`, :issue:`16785`)
df = pd.DataFrame([0], index=pd.DatetimeIndex(['2019-01-01'], tz='US/Pacific'))
df['2019-01-01 12:00:00+04:00':'2019-01-01 13:00:00+04:00']

.. _whatsnew_0250.api_breaking.deps:

Increased minimum versions for dependencies
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

We have updated our minimum supported versions of dependencies (:issue:`23519`).
If installed, we now require:

+-----------------+-----------------+----------+
| Package | Minimum Version | Required |
+=================+=================+==========+
| pytest (dev) | 4.0.2 | |
+-----------------+-----------------+----------+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should put that here, that is only for contributors, not for pandas users?

Copy link
Member

@gfyoung gfyoung Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche : This type of reporting was already done in 0.24.0, though I could go either way on this from a "standards" perspective.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kinda exposed to users via pd.test, so let's keep.


.. _whatsnew_0250.api.other:

Other API Changes
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dependencies:
- hypothesis>=3.82
- isort
- moto
- pytest>=4.0
- pytest>=4.0.2
- pytest-mock
- sphinx
- numpydoc
Expand Down
2 changes: 1 addition & 1 deletion pandas/util/_tester.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def test(extra_args=None):
try:
import pytest
except ImportError:
raise ImportError("Need pytest>=3.0 to run tests")
raise ImportError("Need pytest>=4.0.2 to run tests")
try:
import hypothesis # noqa
except ImportError:
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ gitpython
hypothesis>=3.82
isort
moto
pytest>=4.0
pytest>=4.0.2
pytest-mock
sphinx
numpydoc
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ split_penalty_after_opening_bracket = 1000000
split_penalty_logical_operator = 30

[tool:pytest]
minversion = 4.0.2
testpaths = pandas
markers =
single: mark a test as single cpu only
Expand Down