MyPy CI Configuration #25844
MyPy CI Configuration #25844
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25844 +/- ##
===========================================
- Coverage 91.3% 41.77% -49.54%
===========================================
Files 173 173
Lines 53004 53004
===========================================
- Hits 48397 22142 -26255
- Misses 4607 30862 +26255
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25844 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 175 175
Lines 52885 52885
=======================================
Hits 48381 48381
Misses 4504 4504
Continue to review full report at Codecov.
|
|
ci/code_checks.sh |
|
Yep thanks - was in the process of updating that and actually just pushed. Wasn't sure where Azure created the environment to run that script but may not matter for this |
| axis=0, # type: libinternals.BlockPlacement | ||
| fill_value=None): # type: Any | ||
| # type: (...) -> List[ExtensionBlock] | ||
| periods: int, |
There was a problem hiding this comment.
This was kind of annoying to fix some syntax issues and make this work with LINT so I just converted to new syntax to avoid hassle
|
Do I just need to add mypy to setup.cfg to get that installed? |
|
how does this not fail the CI? |
|
Yea I doubt it’s even running. I think I have to add something to the Checks_and_Docs jobs to actually get it to run though I can’t see where that is defined.
Do I need to be an Admin in Azure for that? @datapythonista any insights?
… On Mar 23, 2019, at 1:06 PM, Jeff Reback ***@***.***> wrote:
how does this not fail the CI?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#25844 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAlOUVzAlNE8dwbyTlJNMt7bvnMuYFFPks5vZok_gaJpZM4cEqu3>.
|
|
you need to add to azure-pipelines.yml |
|
Ah OK thanks - kept looking in the ci folder so no wonder I couldn't find it...just pushed some updates which hopefully should fail typing. |
|
OK mypy failures showing up in logs as expected, so looks like the CI side is configured: Going to push now looking only at a whitelist of modules should go green |
mypy_whitelist.txt
Outdated
| @@ -0,0 +1,4 @@ | |||
| pandas/core/arrays/base.py | |||
There was a problem hiding this comment.
can you add some comments here to indicate what this file is. Also can you add a small new doc section on typing (just a starter is good, can expand over time). on how to type / how to update this file etc.
mypy_whitelist.txt
Outdated
| @@ -0,0 +1,4 @@ | |||
| pandas/core/arrays/base.py | |||
| pandas/core/arrays/datetimes.py | |||
| pandas/core/common.py | |||
There was a problem hiding this comment.
really wish this were a blacklist file :>
|
also its worth a note in the whatsnew, maybe in a development section? eventually we will want to expose pandas.typing but not yet. |
|
OK latest commit goes with an alternate strategy to blacklist individual modules. It's more verbose but is self-contained within the configuration file and is probably easier to manage and orient tasks for in a project. Let me know what you think |
|
@jreback all green |
|
thanks! |
I think this is the minimal amount of work required to get MyPy configured for CI. Note that the list of files is the only documented way to whitelist things that I could find (see also python/mypy#1476)
I think we want to add this to the Checks_and_doc job though I couldn't see where that was actually configured (maybe an access thing on Azure?) so can do as a quick follow up
@jreback @gwrome