Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Improve links and fix issues on resample documentation page #26306

Merged
merged 3 commits into from
May 9, 2019
Merged

DOC: Improve links and fix issues on resample documentation page #26306

merged 3 commits into from
May 9, 2019

Conversation

bharatr21
Copy link
Contributor

@bharatr21 bharatr21 commented May 7, 2019

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #26306 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26306      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52302    52302              
==========================================
- Hits        48142    48138       -4     
- Misses       4160     4164       +4
Flag Coverage Δ
#multiple 90.59% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 93.57% <ø> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.01% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fa58d...6458161. Read the comment docs.

@jreback jreback added Docs Frequency DateOffsets labels May 7, 2019
@jreback jreback added this to the 0.25.0 milestone May 7, 2019
pandas/core/generic.py Outdated Show resolved Hide resolved
@jreback
Copy link
Contributor

jreback commented May 7, 2019

small comment, otherwise lgtm. ping on green.

@bharatr21
Copy link
Contributor Author

The error is AttributeError: type object 'DataFrame' has no attribute 'to_panel' which seems to be unrelated to the current PR. @jreback Any suggestions?

@WillAyd
Copy link
Member

WillAyd commented May 7, 2019

@Bharat123rox I think #26308 will resolve that so can just merge master here after that goes in

@bharatr21
Copy link
Contributor Author

Ping @jreback to review

@jreback jreback merged commit 17247ed into pandas-dev:master May 9, 2019
@jreback
Copy link
Contributor

jreback commented May 9, 2019

thanks @Bharat123rox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links on resample documentation page are broken
3 participants