Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove convert_objects #26612

Merged
merged 4 commits into from
Jun 2, 2019

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added the Clean label Jun 2, 2019
@mroeschke mroeschke added this to the 0.25.0 milestone Jun 2, 2019
@codecov
Copy link

codecov bot commented Jun 2, 2019

Codecov Report

Merging #26612 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26612      +/-   ##
==========================================
- Coverage   91.85%   91.83%   -0.03%     
==========================================
  Files         174      174              
  Lines       50722    50718       -4     
==========================================
- Hits        46593    46579      -14     
- Misses       4129     4139      +10
Flag Coverage Δ
#multiple 90.38% <ø> (-0.02%) ⬇️
#single 41.78% <ø> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 93.61% <ø> (-0.02%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/dtypes/cast.py 90.54% <0%> (-1%) ⬇️
pandas/core/frame.py 97% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437efa6...04eda79. Read the comment docs.

@simonjayhawkins simonjayhawkins added Dtype Conversions Unexpected or buggy dtype conversions Deprecate Functionality to remove in pandas labels Jun 2, 2019
@jreback
Copy link
Contributor

jreback commented Jun 2, 2019

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=12188

looks like a doc-string test still has this, otherwise lgtm.

@jreback jreback merged commit 4f332f6 into pandas-dev:master Jun 2, 2019
@jreback
Copy link
Contributor

jreback commented Jun 2, 2019

thanks @mroeschke

@mroeschke mroeschke deleted the remove_convert_objects branch June 3, 2019 15:11
vaibhavhrt pushed a commit to vaibhavhrt/pandas that referenced this pull request Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants