Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Series.ftype, Series.ftypes and DataFrame.ftypes features #26744

Merged
merged 15 commits into from
Jun 11, 2019
Merged

Deprecated Series.ftype, Series.ftypes and DataFrame.ftypes features #26744

merged 15 commits into from
Jun 11, 2019

Conversation

thiviyanT
Copy link
Contributor

@thiviyanT thiviyanT commented Jun 8, 2019

Deprecation of Series.ftype, Series.ftypes and DataFrame.ftypes
closes #26705

  • Updated the docstrings for the sphinx documentation
  • Updated the unit tests for testing deprecation warnings

@jreback jreback added the Deprecate Functionality to remove in pandas label Jun 8, 2019
@jreback jreback mentioned this pull request Jun 8, 2019
34 tasks
@jreback jreback added this to the 0.25.0 milestone Jun 8, 2019
@thiviyanT
Copy link
Contributor Author

@jreback @jorisvandenbossche - Any idea why these builds are failing?

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #26744 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26744      +/-   ##
==========================================
- Coverage   91.78%   91.77%   -0.01%     
==========================================
  Files         174      174              
  Lines       50706    50709       +3     
==========================================
- Hits        46541    46540       -1     
- Misses       4165     4169       +4
Flag Coverage Δ
#multiple 90.37% <100%> (ø) ⬆️
#single 41.81% <0%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 93.62% <100%> (+0.01%) ⬆️
pandas/core/generic.py 93.64% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a7f61...2c80a30. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #26744 into master will decrease coverage by 1.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26744      +/-   ##
==========================================
- Coverage   91.78%   90.31%   -1.48%     
==========================================
  Files         174      178       +4     
  Lines       50706    50774      +68     
==========================================
- Hits        46541    45854     -687     
- Misses       4165     4920     +755
Flag Coverage Δ
#multiple 90.31% <100%> (-0.07%) ⬇️
#single ?
Impacted Files Coverage Δ
pandas/core/series.py 93.64% <100%> (+0.02%) ⬆️
pandas/core/generic.py 93.91% <100%> (+0.27%) ⬆️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/core/computation/pytables.py 62.5% <0%> (-27.75%) ⬇️
pandas/io/pytables.py 63.82% <0%> (-26.48%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/computation/common.py 84.21% <0%> (-5.27%) ⬇️
pandas/core/config_init.py 92.91% <0%> (-3.94%) ⬇️
pandas/core/computation/expr.py 94.5% <0%> (-3.03%) ⬇️
pandas/io/clipboard/clipboards.py 31.88% <0%> (-2.9%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a7f61...e0d6971. Read the comment docs.

@thiviyanT thiviyanT closed this Jun 9, 2019
@thiviyanT thiviyanT reopened this Jun 9, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, pls add a note in the whatsnew Deprecation section.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThiviyanThanapalasingam thanks for the PR!
I added a bunch of small suggestions (just some wording to be more explicit), normally you should be able to accept those suggestions through the github UI.

Looks good for the rest!

doc/source/whatsnew/v0.25.0.rst Outdated Show resolved Hide resolved
pandas/core/generic.py Outdated Show resolved Hide resolved
pandas/core/generic.py Outdated Show resolved Hide resolved
pandas/core/series.py Outdated Show resolved Hide resolved
pandas/core/series.py Outdated Show resolved Hide resolved
pandas/core/series.py Outdated Show resolved Hide resolved
pandas/core/series.py Outdated Show resolved Hide resolved
thiviyanT and others added 7 commits June 10, 2019 22:46
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-Authored-By: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@thiviyanT
Copy link
Contributor Author

Great! Appreciate the feedback.

@jreback jreback merged commit 157a4e3 into pandas-dev:master Jun 11, 2019
@jreback
Copy link
Contributor

jreback commented Jun 11, 2019

thanks @ThiviyanThanapalasingam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Series.ftype / DataFrame.ftypes
4 participants