Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: remove deprecated date casting; closes #21359 #27109

Merged
merged 5 commits into from
Jul 31, 2019

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added Deprecate Functionality to remove in pandas Timeseries labels Jun 28, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this might be a bit premature and should wait for 1.0, or is this blocking other things?

cc @TomAugspurger @jorisvandenbossche

@jbrockmendel
Copy link
Member Author

Not blocking, but in #21359 the discussed plan was to remove in 0.24.0

@TomAugspurger
Copy link
Contributor

Reading through #21359, it seems like @jreback and @jorisvandenbossche preferred a bit longer of a deprecation. I don't have a preference.

@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Jun 30, 2019
@jreback
Copy link
Contributor

jreback commented Jul 31, 2019

this is probably mergable for 1.0, can you rebase

@jbrockmendel
Copy link
Member Author

Rebased

@TomAugspurger TomAugspurger merged commit 7039f6a into pandas-dev:master Jul 31, 2019
@TomAugspurger
Copy link
Contributor

Thanks.

@jbrockmendel jbrockmendel deleted the fixdate branch July 31, 2019 20:38
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Timeseries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert changes to comparison between Series[datetime64ns] and datetime.date
5 participants