CLN: convert argument in .take method #27171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Jul 1, 2019
doc/source/whatsnew/v0.25.0.rst
Outdated
| @@ -645,6 +645,7 @@ Removal of prior version deprecations/changes | |||
| - Removed the previously deprecated ``ordered`` and ``categories`` keyword arguments in ``astype`` (:issue:`17742`) | |||
| - Removed the previously deprecated ``cdate_range`` (:issue:`17691`) | |||
| - Removed the previously deprecated ``True`` option for the ``dropna`` keyword argument in :func:`SeriesGroupBy.nth` (:issue:`17493`) | |||
| - Removed the previously deprecated ``covert`` keyword argument in :meth:`Series.take` (:issue:`17352`) | |||
There was a problem hiding this comment.
Suggested change
| - Removed the previously deprecated ``covert`` keyword argument in :meth:`Series.take` (:issue:`17352`) | |
| - Removed the previously deprecated ``convert`` keyword argument in :meth:`Series.take` (:issue:`17352`) |
There was a problem hiding this comment.
Also, I don't recall it being just limited to Series.take...
gfyoung
approved these changes
Jul 2, 2019
|
so i think we can collapse _take back into take; it was split out to be the internal take to accomdate this deprecation. can be a separate PR if u want (make an issue though) |
|
Created #27174 for the follow up consolidation. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff