Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: make Categorical.ravel() return Categorical #27199

Merged
merged 7 commits into from Jul 3, 2019

Conversation

@jbrockmendel
Copy link
Member

commented Jul 3, 2019

Discussed in #27142.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jsexauer jsexauer referenced this pull request Jul 3, 2019

Open

DEPR: deprecations from prior versions #6581

0 of 89 tasks complete

@jreback jreback added this to the 0.25.0 milestone Jul 3, 2019

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

conflict and failing

pandas/tests/extension/test_categorical.py(100,): error :  Found unwanted pattern:         with pytest.warns(FutureWarning, match="will return a Categorical")

otherwise lgtm.

@@ -2,6 +2,9 @@


class BaseExtensionTests:
# Whether the EA being tested supports __setitem__
_supports_setitem = True

This comment has been minimized.

Copy link
@jreback

jreback Jul 3, 2019

Contributor

I guess this is ok, but in reality you should have a class which does this (future PR)

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

I am a little concerned by the change in testing pattern this introduces. Could we remove this for now.

@jbrockmendel

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

testing pattern reverted

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

lgtm. merge on green.

@jreback jreback merged commit 1659fff into pandas-dev:master Jul 3, 2019

14 checks passed

codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 92.77% (target 82%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20190703.82 succeeded
Details
pandas-dev.pandas (Checks) Checks succeeded
Details
pandas-dev.pandas (Docs) Docs succeeded
Details
pandas-dev.pandas (Linux py35_compat) Linux py35_compat succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow) Linux py36_locale_slow succeeded
Details
pandas-dev.pandas (Linux py36_locale_slow_old_np) Linux py36_locale_slow_old_np succeeded
Details
pandas-dev.pandas (Linux py37_locale) Linux py37_locale succeeded
Details
pandas-dev.pandas (Linux py37_np_dev) Linux py37_np_dev succeeded
Details
pandas-dev.pandas (Windows py36_np15) Windows py36_np15 succeeded
Details
pandas-dev.pandas (Windows py37_np141) Windows py37_np141 succeeded
Details
pandas-dev.pandas (macOS py35_macos) macOS py35_macos succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the jbrockmendel:catravel branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.