arrays/period: allow parsing of PeriodDtype columns from read_csv #27380
Conversation
|
Hello @chibby0ne! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-17 01:10:07 UTC |
chibby0ne
force-pushed
the
parse_periodtype_columns_read_csv
branch
2 times, most recently
from
bcfaeed
to
457288d
Compare
Done! Thank you for the swift reply ;)! |
|
Can someone explain how the codecov/project failed? It looks as if the coverage in all the files dropped, even though I only changed 2 files. |
Happens sometimes, seems random. Rebase and push again and it usually fixes itself |
Fixes: pandas-dev#26934 Signed-off-by: Antonio Gutierrez <chibby0ne@gmail.com>
chibby0ne
force-pushed
the
parse_periodtype_columns_read_csv
branch
from
457288d
to
ba5f438
Compare
Weird. Thanks for the suggestion though ;) |
doc/source/whatsnew/v0.25.0.rst
Outdated
| @@ -1186,6 +1186,7 @@ ExtensionArray | |||
| - :meth:`Series.count` miscounts NA values in ExtensionArrays (:issue:`26835`) | |||
| - Added ``Series.__array_ufunc__`` to better handle NumPy ufuncs applied to Series backed by extension arrays (:issue:`23293`). | |||
| - Keyword argument ``deep`` has been removed from :meth:`ExtensionArray.copy` (:issue:`27083`) | |||
| - Allow parsing of `PeriodDType` columns when using `read_csv()` (:issue:`26934`) | |||
There was a problem hiding this comment.
| - Allow parsing of `PeriodDType` columns when using `read_csv()` (:issue:`26934`) | |
| - Allow parsing of :class:`PeriodDtype` columns when using `read_csv()` (:issue:`26934`) |
doc/source/whatsnew/v0.25.0.rst
Outdated
| @@ -1186,6 +1186,7 @@ ExtensionArray | |||
| - :meth:`Series.count` miscounts NA values in ExtensionArrays (:issue:`26835`) | |||
| - Added ``Series.__array_ufunc__`` to better handle NumPy ufuncs applied to Series backed by extension arrays (:issue:`23293`). | |||
| - Keyword argument ``deep`` has been removed from :meth:`ExtensionArray.copy` (:issue:`27083`) | |||
| - Allow parsing of :class:`PeriodDtype` columns when using `read_csv()` (:issue:`26934`) | |||
There was a problem hiding this comment.
this should be in the IO section
use :func:`read_csv`
There was a problem hiding this comment.
Done thanks a lot for the quick feedback again!
chibby0ne
force-pushed
the
parse_periodtype_columns_read_csv
branch
from
48d746b
to
074fdbc
Compare
Signed-off-by: Antonio Gutierrez <chibby0ne@gmail.com>
chibby0ne
force-pushed
the
parse_periodtype_columns_read_csv
branch
from
074fdbc
to
cca5c49
Compare
|
thanks @chibby0ne |
Thank you for your support @jreback @TomAugspurger @jbrockmendel @WillAyd ! |
Fixes: #26934
Signed-off-by: Antonio Gutierrez chibby0ne@gmail.com
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff