Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .. versionadded:: 0.18 #27463

Merged
merged 1 commit into from Jul 20, 2019
Merged

Conversation

topper-123
Copy link
Contributor

Removed .. versionadded:: 0.18.0 and related text blocks.

@topper-123 topper-123 changed the title Remove .. versonadded:: 0.18 Remove .. versionadded:: 0.18 Jul 19, 2019
@jbrockmendel
Copy link
Member

is the policy something like keeping these for N releases? if so, is/should these be checked for in code_checks?

@topper-123
Copy link
Contributor Author

There isn't a policy at the moment, the previous rounds I've just removed on my own initiative.

I'm not convinced that a policy check is practical, there could be many minor versions or fewer larger versions, and a check wouldn't catch that.

@gfyoung
Copy link
Member

gfyoung commented Jul 19, 2019

There isn't a policy at the moment, the previous rounds I've just removed on my own initiative.

I think it makes to create a policy, but we can do that afterwards. That being said, 0.18.0 is pretty safe to remove. I would consider 0.19.x as well (either here or in a new PR).

@jreback jreback added this to the 1.0 milestone Jul 20, 2019
@jreback jreback merged commit 0e05f55 into pandas-dev:master Jul 20, 2019
@jreback
Copy link
Contributor

jreback commented Jul 20, 2019

thanks @topper-123

yeah certainly anything < 0.20.3 is fair game at this point.

@topper-123 topper-123 deleted the clean_0.18 branch July 20, 2019 20:26
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants