Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: NDFrame.set_axis inplace defaults to false #27525

Closed
wants to merge 10 commits into from
Closed

DEPR: NDFrame.set_axis inplace defaults to false #27525

wants to merge 10 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2019

.. warning::
``inplace=None`` currently falls back to to True, but in a
future version, will default to False. Use inplace=True
explicitly rather than relying on the default.

has been there since #20164, part of 0.21.0

With discussion of plans to deprecate similar functionality from set_index in #24046, it's time to make sure set_axis conforms to the rest of pandas in this.

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #27525 into master will decrease coverage by 50.56%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #27525       +/-   ##
===========================================
- Coverage   92.96%    42.4%   -50.57%     
===========================================
  Files         184      184               
  Lines       50339    50338        -1     
===========================================
- Hits        46799    21346    -25453     
- Misses       3540    28992    +25452
Flag Coverage Δ
#multiple ?
#single 42.4% <50%> (+0.02%) ⬆️
Impacted Files Coverage Δ
pandas/core/generic.py 38.97% <50%> (-55.31%) ⬇️
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/io/gcs.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/s3.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-99.38%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.16%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd2bc1a...8b532e0. Read the comment docs.

@ghost ghost closed this Jul 24, 2019
@ghost ghost reopened this Jul 24, 2019
@ghost ghost closed this Jul 25, 2019
@ghost ghost deleted the set_axis_inplace_default branch July 25, 2019 23:50
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants