Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Reorganize IntervalIndex tests #28800

Merged
merged 5 commits into from Oct 7, 2019

Conversation

jschendel
Copy link
Member

There shouldn't be any behavioral changes here: mostly just moved things around and created new files for better organization. I tried to do separate granular commits, so looking at each commit individually might make things a little more obvious if there are concerns.

Summary:

  • Removed test_interval_new.py
  • Created test_indexing.py for tests specific to indexing methods
    • Nearly all of test_interval_new.py is here
    • Also moved relevant tests from test_interval.py here
  • Created test_base.py for tests inherited from the common Base class
    • Only tests related to common tests should be placed here (i.e. overriding, skipping)
  • Created test_format.py for formatting related methods

All of the above is generally consistent with how the datetime/period indexing tests are organized.

@jschendel jschendel added Testing pandas testing functions or related to the test suite Interval Interval data type Clean labels Oct 5, 2019
@jschendel jschendel added this to the 1.0 milestone Oct 5, 2019
@jschendel jschendel changed the title TST: Restructure IntervalIndex tests TST: Reorganize IntervalIndex tests Oct 5, 2019
@jreback jreback merged commit eca73ac into pandas-dev:master Oct 7, 2019
@jreback
Copy link
Contributor

jreback commented Oct 7, 2019

thanks @jschendel always love to see reorg on tests :->

@jschendel jschendel deleted the intervalindex-tests branch October 8, 2019 18:21
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants