TST: fix 24 xfails in maybe_promote #28833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Edit in internals.concat turns out to be necessary to fix a different test that the maybe_promote edit broke. The relevant code in internals.concat should really use maybe_promote or something similar. Will open an issue to that effect. |
jreback
added
Dtype Conversions
|
thanks @jbrockmendel (hope these were orthogonal!) |
Yep, I'm being pretty careful to keep these orthogonal so we can keep a tight turnaround on these. |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vague gameplan: I think I've got a handle on the
if not boxedxfail tests that are left, will incrementally fix them over a few more steps. Then theif boxedcases all correspond to passingndarrayforfill_value, which never happens in the tests except for dedicated tests designed to do exactly that. If we can rule that case out, we can remove most of the remaining xfails (and a lot of complexity in the test code) in one swoop.