DEPR: MultiIndex.to_hierarchical, labels #29766
Conversation
| if "labels" in kwargs: | ||
| raise TypeError("'labels' argument has been removed; use 'codes' instead") |
There was a problem hiding this comment.
ideally i think we should just get kwargs out of the signature of this function, but im fine with adding a test for this in the interim
Co-Authored-By: Simon Hawkins <simonjayhawkins@gmail.com>
|
Looks like pyarrow is still using the deprecated usage. We aren't pinning the version, and it looks like the py36_macos azure build is using 0.9.0 (which is also what we have listed in Anyone mind bumping the supported pyarrow min version to 0.12.0? cc @jorisvandenbossche |
|
ok with bumping pyarrow |
|
bumped pyarrow min version to 0.12.0 and updated usages |
doc/source/whatsnew/v1.0.0.rst
Outdated
| | Package | Minimum Version | Required | | ||
| +=================+=================+==========+ | ||
| | numpy | 1.13.3 | X | | ||
| +-----------------+-----------------+----------+ |
There was a problem hiding this comment.
can u add a column that has an X if it changed in this version from previous (eg mark pyarrow)
| @@ -16,7 +16,7 @@ | |||
| "odfpy": "1.3.0", | |||
| "openpyxl": "2.4.8", | |||
| "pandas_gbq": "0.8.0", | |||
| "pyarrow": "0.9.0", | |||
| "pyarrow": "0.12.0", | |||
There was a problem hiding this comment.
@datapythonista here we need to update pytest
There was a problem hiding this comment.
Thanks for the clarification, I found it. It's already implemented in #29782
|
The azure mac-py36 build has numpy=1.13.3 pinned but pyarrow0.12.0 requires numpy>= 1.14.0 Should we bump the numpy pin in this build or remove pyarrow? |
|
or we could just bump the numpy min version. 1.13.3 was released 2017-09-29 |
|
we should bump numpy anyhow to 1.14/1.15 let’ |
|
for now bumped the pin in this build to 1.14, can bump the numpy min ver in a dedicated PR |
|
Bumping pyarrow to 0.12 is certainly OK I think! |
| +-----------------+-----------------+----------+---------+ | ||
| | numexpr | 2.6.2 | | | | ||
| +-----------------+-----------------+----------+---------+ | ||
| | pytest (dev) | 4.0.2 | | | |
There was a problem hiding this comment.
can you update this to 5.0.1 with an X next time you change something in whatsnew, cc @datapythonista
|
|
||
| if issubclass(cls, ABCMultiIndex): | ||
| if "labels" in d and "codes" not in d: | ||
| # GH#23752 "labels" kwarg has been replaced with "codes" |
There was a problem hiding this comment.
do we have an issue about removing this code at some point, what are the pre-conditions for that?
There was a problem hiding this comment.
what are the pre-conditions for that?
not wanting/needing to support sufficiently-old pickles
There was a problem hiding this comment.
can you clarify, meaning < 0.23.4? later? (if you can pls put in the issue)
|
thanks, 2 small followons. |
No description provided.