Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing #2057, s/assert/raise AssertionError/g #3023

Merged
1 commit merged into from Apr 23, 2013
Merged

Continuing #2057, s/assert/raise AssertionError/g #3023

1 commit merged into from Apr 23, 2013

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2013

#2057

Though I've never encountered usage of python -O in the wild.

@ghost
Copy link
Author

ghost commented Mar 12, 2013

set to 0.12, to be merged right after 0.11, since it touches all manner of things
and needs testing before inclusion in a release.

@wesm
Copy link
Member

wesm commented Mar 28, 2013

Seems pretty uncontroversial to me. I'd be happy merging?

@ghost
Copy link
Author

ghost commented Mar 28, 2013

Up to you. there's no real benefit to users, and it's too many changes to be sure
I haven't missed a semicolon somewhere. I prefer 0.12 - there's already a bunch
of refactors queued up for right after 0.11, might as well save it for the party.

ghost pushed a commit that referenced this pull request Apr 23, 2013
Continuing #2057, s/assert/raise AssertionError/g
@ghost ghost merged commit 464dd3d into pandas-dev:master Apr 23, 2013
@ghost ghost deleted the no_asserts branch April 23, 2013 02:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant