BUG: raise on non-hashable Index name, closes #29069 #30335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To close #29069, Index.name should probably be a settable property, and the setter should validate that the name is hashable. Any perf concerns here? Things should be OK right? |
|
huh, looks like i got confused by |
jreback
requested changes
Dec 20, 2019
jreback
reviewed
Dec 20, 2019
|
Are we OK with being able to set MultiIndex.name? When I tried disallowing it, some tests broke |
|
xref #11979 should we try to address that here while were at it? |
jreback
requested changes
Dec 24, 2019
pandas/core/indexes/base.py
Outdated
|
|
||
| # GH#29069 | ||
| if not is_hashable(name): | ||
| raise TypeError(f"{cls_name}.name must be a hashable type") |
There was a problem hiding this comment.
can you use type(obj).name here?
pandas/core/indexes/base.py
Outdated
| @@ -5464,3 +5472,19 @@ def default_index(n): | |||
| from pandas.core.indexes.range import RangeIndex | |||
|
|
|||
| return RangeIndex(0, n, name=None) | |||
|
|
|||
|
|
|||
| def maybe_extract_name(name, obj, cls_name="Index"): | |||
There was a problem hiding this comment.
can you type and add a doc-string
|
I think #19171 becomes easier after this. |
jreback
reviewed
Dec 27, 2019
|
|
||
| @name.setter | ||
| def name(self, value): | ||
| maybe_extract_name(value, None, type(self)) |
There was a problem hiding this comment.
in series.py you can change name.setter to use maybe_extract_name (ok for followon)
jreback
approved these changes
Dec 27, 2019
| @@ -5462,3 +5470,19 @@ def default_index(n): | |||
| from pandas.core.indexes.range import RangeIndex | |||
|
|
|||
| return RangeIndex(0, n, name=None) | |||
|
|
|||
|
|
|||
| def maybe_extract_name(name, obj, cls) -> Optional[Hashable]: | |||
There was a problem hiding this comment.
see my comment above, can be more general so need to relocate i think as this is common between series/index)
|
thanks |
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
keechongtan
added a commit
to keechongtan/pandas
that referenced
this pull request
Dec 29, 2019
…ndexing-1row-df * upstream/master: (333 commits) CI: troubleshoot Web_and_Docs failing (pandas-dev#30534) WARN: Ignore NumbaPerformanceWarning in test suite (pandas-dev#30525) DEPR: camelCase in offsets, get_offset (pandas-dev#30340) PERF: implement scalar ops blockwise (pandas-dev#29853) DEPR: Remove Series.compress (pandas-dev#30514) ENH: Add numba engine for rolling apply (pandas-dev#30151) [ENH] Add to_markdown method (pandas-dev#30350) DEPR: Deprecate pandas.np module (pandas-dev#30386) ENH: Add ignore_index for df.drop_duplicates (pandas-dev#30405) BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots pandas-dev#30288 (pandas-dev#30491) CI: Fix GBQ Tests (pandas-dev#30478) Bug groupby quantile listlike q and int columns (pandas-dev#30485) ENH: Add ignore_index for df.sort_values and series.sort_values (pandas-dev#30402) TYP: Typing hints in pandas/io/formats/{css,csvs}.py (pandas-dev#30398) BUG: raise on non-hashable Index name, closes pandas-dev#29069 (pandas-dev#30335) Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886 (pandas-dev#30502) BUG: preserve EA dtype in transpose (pandas-dev#30091) BLD: add check to prevent tempita name error, clsoes pandas-dev#28836 (pandas-dev#30498) REF/TST: method-specific files for test_append (pandas-dev#30503) marked unused parameters (pandas-dev#30504) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff