Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: DataFrame GroupBy indexing with single items DeprecationWarning #30546

Merged
merged 11 commits into from Jan 3, 2020
Merged

DEPR: DataFrame GroupBy indexing with single items DeprecationWarning #30546

merged 11 commits into from Jan 3, 2020

Conversation

yehoshuadimarsky
Copy link
Contributor

@yehoshuadimarsky yehoshuadimarsky commented Dec 29, 2019 •
edited

@jbrockmendel
Copy link
Member

theres another FutureWarning you need to catch in test_getitem_numeric_column_names

@pep8speaks
Copy link

pep8speaks commented Dec 29, 2019 •
edited

Hello @yehoshuadimarsky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-02 04:05:51 UTC

@simonjayhawkins simonjayhawkins changed the title BUG: DataFrame GroupBy indexing with single items DeprecationWarning DEPR: DataFrame GroupBy indexing with single items DeprecationWarning Dec 30, 2019
@simonjayhawkins simonjayhawkins added Deprecate Functionality to remove in pandas Groupby labels Dec 30, 2019
jreback
jreback requested changes Jan 1, 2020
View reviewed changes
pandas/core/groupby/generic.py Outdated Show resolved Hide resolved
doc/source/whatsnew/v1.0.0.rst Outdated Show resolved Hide resolved
pandas/tests/groupby/test_grouping.py Outdated Show resolved Hide resolved
pandas/tests/groupby/test_grouping.py Outdated Show resolved Hide resolved
yehoshuadimarsky
yehoshuadimarsky commented Jan 2, 2020
View reviewed changes
Copy link
Contributor Author

@yehoshuadimarsky yehoshuadimarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up per @jreback suggestions, thanks for the pointers.

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 2, 2020
Closed
@jreback jreback added this to the 1.0 milestone Jan 3, 2020
@jreback jreback merged commit 6fc9852 into pandas-dev:master Jan 3, 2020
@jreback
Copy link
Contributor

jreback commented Jan 3, 2020

thanks @yehoshuadimarsky very nice

@yehoshuadimarsky
Copy link
Contributor Author

Thanks! My first pandas PR, pretty cool

@yehoshuadimarsky yehoshuadimarsky deleted the groupby-select-list-fix branch January 3, 2020 03:05
@rhshadrach rhshadrach mentioned this pull request Sep 12, 2020
Open
@mroeschke mroeschke mentioned this pull request Oct 25, 2022
Merged
@tehunter tehunter mentioned this pull request Apr 16, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

API: DataFrameGroupBy column subset selection with single list?
5 participants
@yehoshuadimarsky @jbrockmendel @pep8speaks @jreback @simonjayhawkins