Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Updated version of macos image #31292

Merged
merged 4 commits into from
Jan 25, 2020

Conversation

ShaharNaveh
Copy link
Member

@@ -4,7 +4,7 @@ jobs:
- template: ci/azure/posix.yml
parameters:
name: macOS
vmImage: xcode9-macos10.13
vmImage: macos10.15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I would be OK with macos-latest - I don't see a need to pin a particular version

Copy link
Member

@WillAyd WillAyd Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I would be OK with macos-latest - I don't see a need to pin a particular version

Though so as well, but I figured that xcode9-macos10.13 is there for a reason, apparently I was wrong

@WillAyd WillAyd added the CI Continuous Integration label Jan 24, 2020
@ShaharNaveh
Copy link
Member Author

Will #30990 work after this change?

does gcc support macos 10.15?

@WillAyd WillAyd added this to the 1.0.0 milestone Jan 24, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd
Copy link
Member

WillAyd commented Jan 24, 2020

Hmm though looks like the macOS build is stuck in queued

@ShaharNaveh
Copy link
Member Author

Hmm though looks like the macOS build is stuck in queued

@WillAyd Not anymore, I guess it was downloading the image or refreshing the cache.

Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using latest is a little dicey IMO.

You don't know what incompatibilities newer versions may (unexpectedly) introduce. I think pinning to the latest (numeric) version as was done before is best.

I don't necessarily object to testing against macos-latest. However, I would mark that build as an allowable failure (though not sure how one does that with Azure pipelines).

@jreback jreback merged commit a8c7bcc into pandas-dev:master Jan 25, 2020
@jreback
Copy link
Contributor

jreback commented Jan 25, 2020

seems reasonable

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 25, 2020
jreback pushed a commit that referenced this pull request Jan 25, 2020
Co-authored-by: MomIsBestFriend <50263213+MomIsBestFriend@users.noreply.github.com>
keechongtan added a commit to keechongtan/pandas that referenced this pull request Jan 27, 2020
…ndexing-1row-df

* upstream/master: (194 commits)
  DOC Remove Python 2 specific comments from documentation (pandas-dev#31198)
  Follow up PR: pandas-dev#28097 Simplify branch statement (pandas-dev#29243)
  BUG: DatetimeIndex.snap incorrectly setting freq (pandas-dev#31188)
  Move DataFrame.info() to live with similar functions (pandas-dev#31317)
  ENH: accept a dictionary in plot colors (pandas-dev#31071)
  PERF: add shortcut to Timestamp constructor (pandas-dev#30676)
  CLN/MAINT: Clean and annotate stata reader and writers (pandas-dev#31072)
  REF: define _get_slice_axis in correct classes (pandas-dev#31304)
  BUG: DataFrame.floordiv(ser, axis=0) not matching column-wise bheavior (pandas-dev#31271)
  PERF: optimize is_scalar, is_iterator (pandas-dev#31294)
  BUG: Series rolling count ignores min_periods (pandas-dev#30923)
  xfail sparse warning; closes pandas-dev#31310 (pandas-dev#31311)
  REF: DatetimeIndex.get_value wrap DTI.get_loc (pandas-dev#31314)
  CLN: internals.managers (pandas-dev#31316)
  PERF: avoid copies if possible in fill_binop (pandas-dev#31300)
  Add test for multiindex json (pandas-dev#31307)
  BUG: passing TDA and wrong freq to TimedeltaIndex (pandas-dev#31268)
  BUG: inconsistency between PeriodIndex.get_value vs get_loc (pandas-dev#31172)
  CLN: remove _set_subtyp (pandas-dev#31301)
  CI: Updated version of macos image (pandas-dev#31292)
  ...
@ShaharNaveh ShaharNaveh deleted the CI-azurepipelines branch January 30, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: update azure VM image
4 participants