REGR: Fixed handling of Categorical in cython ops #31668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed by falling back to the wrapped Python version when the cython version raises NotImplementedError. Closes pandas-dev#31450
TomAugspurger
added
Groupby
Regression
5 tasks
|
LGTM. Is this the long-term solution? |
|
I'm not really sure to be honest. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 5, 2020
|
this looks good. it should be the long-term, until we fully handle EAs in cython. |
jorisvandenbossche
pushed a commit
that referenced
this pull request
Feb 5, 2020
…#31678) Co-authored-by: Tom Augspurger <TomAugspurger@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by falling back to the wrapped Python version when the cython
version raises NotImplementedError.
Closes #31450