Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure valid Block mutation in SeriesBinGrouper. #32561

Merged
merged 9 commits into from
Mar 11, 2020
Merged

Ensure valid Block mutation in SeriesBinGrouper. #32561

merged 9 commits into from
Mar 11, 2020

Commits on Mar 9, 2020

  1. REGR: Expand ValueError catching in series aggregate 

    Closes pandas-dev#31802

This "fixes" pandas-dev#31802 by expanding the number of cases where we swallow an
exception in libreduction. Currently, we're creating an invalid Series
in SeriesBinGrouper where the `.mgr_locs` doesn't match the values. See
pandas-dev#31802 (comment)
for more.

For now, we simply catch more cases that fall back to Python. I've gone
with a minimal change which addresses only issues hitting this exact
exception. We might want to go broader, but that's not clear.
    @TomAugspurger
    TomAugspurger committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    5007426 View commit details
    Browse the repository at this point in the history

  2. update mgr_locs

    @TomAugspurger
    TomAugspurger committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    ad746ba View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. revert

    @TomAugspurger
    TomAugspurger committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    922b30d View commit details
    Browse the repository at this point in the history

  2. TST: separate out pd.crosstab tests from test_pivot (pandas-dev#32536)

    @jbrockmendel @TomAugspurger
    jbrockmendel authored and TomAugspurger committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    f63acd3 View commit details
    Browse the repository at this point in the history

  3. CLN: remove Categorical.put (pandas-dev#32554)

    @jbrockmendel @TomAugspurger
    jbrockmendel authored and TomAugspurger committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    7e49bd5 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into 31802-groupby-reg… 

    …ression
    @TomAugspurger
    TomAugspurger committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    26ecad8 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Merge remote-tracking branch 'upstream/master' into 31802-groupby-reg… 

    …ression
    @TomAugspurger
    TomAugspurger committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    cb5d20f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into 31802-groupby-reg… 

    …ression
    @TomAugspurger
    TomAugspurger committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    4649033 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into 31802-groupby-reg… 

    …ression
    @TomAugspurger
    TomAugspurger committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7060dd3 View commit details
    Browse the repository at this point in the history