Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Categorical.to_dense #32639

Merged
merged 5 commits into from Mar 15, 2020
Merged

DEPR: Categorical.to_dense #32639

merged 5 commits into from Mar 15, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Mar 11, 2020 •
edited

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Ideally I'd want to keep the method and change the behavior to (an improved variant of) _internal_get_values, but so it goes.

@jbrockmendel jbrockmendel added the Deprecate Functionality to remove in pandas label Mar 12, 2020
@jreback jreback added this to the 1.1 milestone Mar 14, 2020
@jreback jreback added the Categorical Categorical Data Type label Mar 14, 2020
@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

can you add a release note & link to the deprecation removal issue.

@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 14, 2020
Closed
@jreback
Copy link
Contributor

jreback commented Mar 14, 2020 •
edited

rebase again pls

@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@jreback jreback merged commit 7a24c35 into pandas-dev:master Mar 15, 2020
@jreback
Copy link
Contributor

jreback commented Mar 15, 2020

thanks

@jbrockmendel jbrockmendel deleted the depr-cat-to_dense branch March 15, 2020 01:27
@jorisvandenbossche jorisvandenbossche mentioned this pull request Mar 16, 2020
Open
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@jbrockmendel @SeeminSyed
DEPR: Categorical.to_dense (pandas-dev#32639)
64f96e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbrockmendel @jreback