DEPR: deprecate dtype param in Index.copy #35853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
commented
Aug 22, 2020
| @@ -1030,7 +1030,6 @@ def _shallow_copy( | |||
| name=lib.no_default, | |||
| levels=None, | |||
| codes=None, | |||
| dtype=None, | |||
There was a problem hiding this comment.
Other index types don't have dtype param in their _shallow_copy signature. Instead do dtype changing inside MultiIndex.copy.
pandas/core/indexes/base.py
Outdated
| @@ -820,6 +823,12 @@ def copy(self, name=None, deep=False, dtype=None, names=None): | |||
| new_index = self._shallow_copy(name=name) | |||
|
|
|||
| if dtype: | |||
| warnings.warn( | |||
| "parameter dtype is deprecated and will be removed in a future version." | |||
| " Use the astype method instead.", | |||
There was a problem hiding this comment.
looks like linter wants the whitespace in the previous line
topper-123
force-pushed
the
deprecate_dtype_in_Index.copy
branch
from
d5be44c
to
a828666
Compare
gfyoung
added
Deprecate
|
thanks @topper-123 |
topper-123
added
Index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
dtypeparam inIndex.copyand child methods. If users want to change dtype, they should useIndex.astype.