BUG: groupby and agg on read-only array gives ValueError: buffer source array is read-only #36061
Conversation
jreback
added
Compat
|
|
||
| if len(values) != len(labels): | ||
| if len_values != len_labels: |
There was a problem hiding this comment.
i think elsewhere we get around this be using values.shape[0] instead of len. IIRC this is something we wont need to do anymore in cython3
There was a problem hiding this comment.
There are indeed a few cases of
# TODO(cython 3.0):
# Instead of `labels.shape[0]` use `len(labels)`
if not len(values) == labels.shape[0]:
in this file. But so if we need to update it anyways after cython 3.0, it doesn't maybe matter that much.
|
LGTM pending Jeff's test request |
Tests for #35436 and #34857? Those issues are not fixed by this PR. Even if I add tests, they'd fail. Unless you mean something else which I am missing. I tried @jbrockmendel's suggestion. Also, should the |
|
|
||
| if len(values) != len(labels): | ||
| if len_values != len_labels: |
|
thanks @jeet-parekh |
… gives ValueError: buffer source array is read-only
…ueError: buffer source array is read-only (#36117) Co-authored-by: Jeet Parekh <12874561+jeet-parekh@users.noreply.github.com>
…ce array is read-only (pandas-dev#36061)
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI found multiple aggregate functions that were failing for a read-only array. I applied the change suggested in #36014 to all of them.
A couple of questions.
len(values) != len(labels). Let me know if there is another preferred way of doing it.len(values) != len(labels)check. Should it be there in all the functions?