DEPR: string indexing along index for datetimes #36179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 7, 2020
jreback
added
Deprecate
placeholder before I had a PR number. just updated |
…pr-str-date-indexing
…pr-str-date-indexing
…pr-str-date-indexing
|
could use some help with the ipython directive errors |
…pr-str-date-indexing
…pr-str-date-indexing
…pr-str-date-indexing
…pr-str-date-indexing
…pr-str-date-indexing
|
ping |
jreback
approved these changes
Sep 24, 2020
|
thanks, can you add the entry to the deprecation removal issue as well when you have a sec |
| @@ -590,24 +595,28 @@ This starts on the very first time in the month, and includes the last date and | |||
| time for the month: | |||
|
|
|||
| .. ipython:: python | |||
| :okwarning: | |||
|
|
|||
| dft['2013-1':'2013-2'] | |||
There was a problem hiding this comment.
This is not actually deprecated, right? (and thus shouldn't raise a warning?)
There was a problem hiding this comment.
Good catch. I think this should be deprecated too.
Edit: On further thought, not sure.
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffLet's get ourselves one less special case to worry about