CLN: sql static method

[erfannariman]

• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

[erfannariman]

Not sure why my commits from #35224 are included in this PR. Maybe because I changed my email in config user.email. But the changes I made for this PR are in sql.py

[MarcoGorelli]

Not sure why my commits from #35224 are included in this PR. Maybe because I changed my email in config user.email. But the changes I made for this PR are in sql.py

I'd guess it's because you created a new branch from your previous one and then added new commits on top of it, instead of resetting to upstream/master before starting new work.

You can get rid of unwanted commits with git rebase -i upstream/master and then dropping any commits you don't want (note that you'll then need to use the -f flag when pushing)

[erfannariman]

Not sure why my commits from #35224 are included in this PR. Maybe because I changed my email in config user.email. But the changes I made for this PR are in sql.py

I'd guess it's because you created a new branch from your previous one and then added new commits on top of it, instead of resetting to upstream/master before starting new work.

You can get rid of unwanted commits with git rebase -i upstream/master and then dropping any commits you don't want (note that you'll then need to use the -f flag when pushing)

Thanks, I can do that, but the changes now look correct, and it does not conflict with the base branch, it's fine like this as well I guess?

[MarcoGorelli]

I think it should be fine, yes :) While you're here modifying these files, can you also add type annotations to the signatures you've changed (where possible)?

[jreback]

-1 on static methods generally; you can move to a free function if you really want

[jorisvandenbossche]

I agree we should generally be using staticmethods only sparingly, but IMO here that is fine. This method is only used once, just above, and keeping it here keeps it closer to where it is used.
The same for _fetchall_as_list. And the get_table is actually overriding a parent class method, so shouldn't be moved to a free function.

So I prefer to keep those functions where they are. Whether they are normal methods or staticmethods, I personally don't care. So if others don't want to use staticmethods, I would just leave this as is.

[erfannariman]

I guess with the -1 and with the leave as is, I will close this PR.