New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REF: dataframe formatters/outputs #36510
Merged
+640
−538
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
c3568a2
REF: drop TableFormatter
ivanovmg 837858f
REF: extract ConsoleFormatter
ivanovmg 08e899f
CLN: remove ConsoleFormatter to_string method
ivanovmg 602c984
REF: move table_id & render_links to HTMLFormatter
ivanovmg bd5cb87
REF: move _join_multiline to ConsoleFormatter
ivanovmg 6e8d4d8
REF: separate dataframe formatting from rendering
ivanovmg cbd3c76
REF: extract _empty_info_line property in latex
ivanovmg 5c30924
DOC: docstrings for DataFrame & String Formatters
ivanovmg af8fe98
REF: make _get_buffer private
ivanovmg 6e9fb3c
REF: pass DataFrameFormatter to CSVFormatter
ivanovmg 878eed2
REF: create to_csv in DataFrameRenderer
ivanovmg d87638b
LINT: imports and line breaks
ivanovmg 1292be5
REF: move StringFormatter to separate module
ivanovmg 41553f6
TYP: handle mypy errors after enabling composition
ivanovmg a66ca5e
REF: remove non-existent parent in LatexFormatter
ivanovmg 3fbe4ba
REF: move line_width to StringFormatter
ivanovmg 733fa34
REF: move need_to_wrap to StringFormatter
ivanovmg bfb37d7
DOC: add docstrings to DataFrame.to_xxx methods
ivanovmg f1b494e
CLN: to_string on top in HTMLFormatter
ivanovmg 75daa74
LINT: black conv multiline -> oneline
ivanovmg 6e39277
DOC: add docstring to DataFrameRenderer
ivanovmg df3b5c6
REF: move _get_result, _get_buffer to module level
ivanovmg 5a18386
REF: replace setters with initializer methods
ivanovmg fc68fa5
REF: extract properties to make composition clear
ivanovmg 19d2156
REF: eliminate inheritance for HTMLFormatter
ivanovmg 271ef5c
LINT: new black
ivanovmg b1018ad
Merge branch 'master' into refactor/fmt
ivanovmg 22d0982
TYP: type properties in CSVFormatter
ivanovmg 94dbadd
TYP: type strcols
ivanovmg 914981b
TYP: _join_multiline
ivanovmg 482ccd1
LINT: sort in one line
ivanovmg 7b57fc8
REF: _join_multiline to accept single arg
ivanovmg 1e2969f
REF: eliminate mutation in _join_multiline
ivanovmg 90977fd
Merge branch 'master' into refactor/fmt
ivanovmg fc7a091
Merge branch 'master' into refactor/fmt
ivanovmg 1335a11
TYP: extract imports for typing only in csvs
ivanovmg b67b481
TYP: move FloatFormatType alias to _typing
ivanovmg File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this TODO still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what it actually means here... :)