[TST]: Add test for duplicate keys in concat #36556
Conversation
|
Test failure seems unrelated |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
pandas/tests/reshape/test_concat.py
Outdated
| # GH: 20816 | ||
| series_list = [pd.Series({"a": 1}), pd.Series({"b": 2}), pd.Series({"c": 3})] | ||
| result = pd.concat(series_list, keys=keys, verify_integrity=integrity) | ||
| tuples = [(first, second) for first, second in zip(keys, ["a", "b", "c"])] |
There was a problem hiding this comment.
I guess this could be simplified.
tuples = list(zip(keys, ["a", "b", "c"]))
There was a problem hiding this comment.
Good point, thank you very much
pandas/tests/reshape/test_concat.py
Outdated
| @pytest.mark.parametrize( | ||
| ("keys", "integrity"), | ||
| [ | ||
| (["red"] * 3, False), | ||
| (["red", "blue", "red"], False), | ||
| (["red", "blue", "red"], True), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Was there a plan to follow the same exact parametrization as in the referenced github issue?
I would suggest to have these tests with verify_integrity=True/False for all keys.
There was a problem hiding this comment.
Was not mentioned as a problem, so I think that was the reason I did not add it. But was more than 4 weeks ago, so I am not quite sure. Added it now.
� Conflicts: � pandas/tests/reshape/test_concat.py
|
can you merge master and ping on green. |
jreback
added
Testing
|
@jreback green |
|
thanks! |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAdded a test