DEPR: Deprecate params levels & codes in MultiIndex.copy #36685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks fine. is there an issue discussing this? |
jreback
requested changes
Sep 27, 2020
pandas/core/indexes/multi.py
Outdated
| @@ -1575,7 +1594,7 @@ def dropna(self, how="any"): | |||
| raise ValueError(f"invalid how option: {how}") | |||
|
|
|||
| new_codes = [level_codes[~indexer] for level_codes in self.codes] | |||
| return self.copy(codes=new_codes, deep=True) | |||
| return self.copy(deep=True).set_codes(codes=new_codes) | |||
There was a problem hiding this comment.
Looking again, the call to .copy isn't needed because a MultiIndex is immutable, so I've removed that call.
|
No issue, so I’m fine discussing it here. My opinion is that copy does too much and removing this makes the API cleaner. |
topper-123
force-pushed
the
depr_multiindex_params
branch
from
9147eed
to
01f2f03
Compare
topper-123
force-pushed
the
depr_multiindex_params
branch
from
01f2f03
to
46b20b8
Compare
jreback
approved these changes
Oct 1, 2020
|
thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates params
levels&codesinMultiIndex.copy.