Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Raise ValueError with nan in timeaware windows #36822

Merged
merged 10 commits into from
Oct 15, 2020
Merged

BUG: Raise ValueError with nan in timeaware windows #36822

merged 10 commits into from
Oct 15, 2020

Conversation

phofl
Copy link
Member

@phofl phofl commented Oct 2, 2020 •
edited
Loading

Raising a ValueError when NaN is in timeaware window.

cc @mroeschke

@phofl phofl added Window rolling, ewma, expanding Error Reporting Incorrect or improved errors from pandas labels Oct 2, 2020
jreback
jreback requested changes Oct 3, 2020
View reviewed changes
pandas/core/window/rolling.py Show resolved Hide resolved
pandas/tests/window/test_grouper.py Outdated Show resolved Hide resolved
@mroeschke mroeschke added this to the 1.2 milestone Oct 4, 2020
@jreback
Copy link
Contributor

jreback commented Oct 7, 2020

this is fine, pls merge master and ping on green.

@phofl
Merge branch 'master' of https://github.com/pandas-dev/pandas into 34617
dc83e68 
� Conflicts:
�	pandas/tests/window/test_grouper.py
@pep8speaks
Copy link

pep8speaks commented Oct 7, 2020 •
edited
Loading

Hello @phofl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-14 19:57:10 UTC

@phofl
Copy link
Member Author

phofl commented Oct 7, 2020

ping @jreback green

@phofl
Merge branch 'master' of https://github.com/pandas-dev/pandas into 34617
fac1cc8 
� Conflicts:
�	doc/source/whatsnew/v1.2.0.rst
�	pandas/tests/window/test_grouper.py
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

the CI / checks are failing. ping on green-ish

@phofl
Copy link
Member Author

phofl commented Oct 10, 2020

@jreback
Thats a bug on master. Looking into this right now.

@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

@jreback
Thats a bug on master. Looking into this right now.

OH!

@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

pandas/core/dtypes/cast.py:501: error: unused 'type: ignore' comment

@phofl
Copy link
Member Author

phofl commented Oct 10, 2020

Fixed it, #37045

@mroeschke
Copy link
Member

Maybe merge master once more on this PR?

@jreback jreback merged commit 31c48ee into pandas-dev:master Oct 15, 2020
@jreback
Copy link
Contributor

jreback commented Oct 15, 2020

thanks @phofl

@phofl phofl deleted the 34617 branch October 15, 2020 18:53
@phofl phofl restored the 34617 branch October 15, 2020 18:53
@phofl phofl deleted the 34617 branch October 15, 2020 18:53
@phofl phofl restored the 34617 branch October 15, 2020 18:54
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@phofl @JulianWgs
BUG: Raise ValueError with nan in timeaware windows (pandas-dev#36822)
58b7b65
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@phofl
BUG: Raise ValueError with nan in timeaware windows (pandas-dev#36822)
f12f3ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Window rolling, ewma, expanding
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

BUG: rolling aggregations not checking monotonic index when grouping by
4 participants
@phofl @jreback @pep8speaks @mroeschke