API: reimplement FixedWindowIndexer.get_window_bounds #37035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jreback
requested changes
Oct 10, 2020
|
cc @mroeschke |
3 tasks
|
Could you also add a whatsnew entry in 1.2? |
|
Looks like there were some failures, but I do not believe those were caused by this PR |
@mroeschke I added a whatsnew entry about the reimplementation and linked Issue 36040, even though it's not technically fixing that issue (the issue was already fixed by your PR). Please lmk if this is what you intended I add, or if you were looking for something else. |
mroeschke
reviewed
Oct 10, 2020
mroeschke
approved these changes
Oct 10, 2020
jreback
approved these changes
Oct 10, 2020
|
thanks @justinessert |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis PR replaces 36132 following @mroeschke's 36567.
Originally, my PR was to fix Issue 36040. But it appears that Matthew's PR already fixed it! Nonetheless, I still included two things from my previous PR:
I don't believe any functionality was altered by this PR so I did not include a whatsnew entry