[REDO] CLN: core/dtypes/cast.py::maybe_downcast_to_dtype #37126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
force-pushed
the
maybe_downcast_to_dtype_cleanup
branch
from
1c9bfe8
to
a0a39ff
Compare
jreback
requested changes
Oct 16, 2020
| @@ -133,7 +134,7 @@ def is_nested_object(obj) -> bool: | |||
| return False | |||
|
|
|||
|
|
|||
| def maybe_downcast_to_dtype(result, dtype: Dtype): | |||
| def maybe_downcast_to_dtype(result, dtype: Union[str, np.dtype]): | |||
There was a problem hiding this comment.
this is not correct, DtypeObj right
There was a problem hiding this comment.
has to be a numpy type or str according to mypy. When I put it DtypeObj mypy errors:
pandas/core/dtypes/cast.py:180: error: Item "ExtensionDtype" of "Union[Any, ExtensionDtype]" has no attribute "freq" [union-attr]
arw2019
force-pushed
the
maybe_downcast_to_dtype_cleanup
branch
from
a0a39ff
to
048508b
Compare
jreback
approved these changes
Oct 17, 2020
|
thanks @arw2019 |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffxref #37050 (comment)
The combination of #37050 and #37024 generated a
mypycomplaint. This PR is resubmission of #37050 with the correct type hint.cc @simonjayhawkins