Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: use overload to refine return type of reset_index #37137

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

simonjayhawkins
Copy link
Member

maybe alternative to #33519

with from __future__ import annotations on py3.7 the types in the function signature are not evaluated at run-time, so this shouldn't fail 馃

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Oct 15, 2020
@jbrockmendel
Copy link
Member

LGTM

@simonjayhawkins simonjayhawkins mentioned this pull request Oct 23, 2020
5 tasks
@WillAyd WillAyd added this to the 1.2 milestone Oct 23, 2020
@WillAyd WillAyd merged commit a8f5477 into pandas-dev:master Oct 23, 2020
@WillAyd
Copy link
Member

WillAyd commented Oct 23, 2020

Cool thanks @simonjayhawkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants