Regression in offsets caused offsets to be no longer hashable #37288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
changed the title
phofl
added
Timeseries
Regression
jreback
requested changes
Oct 20, 2020
|
great code change looks good. if you'd report on the asv's we can merge. |
|
Thanks, benchmark has just finished. No changes
|
jreback
approved these changes
Oct 20, 2020
jreback
reviewed
Oct 20, 2020
pandas/_libs/tslibs/offsets.pyx
Outdated
| @@ -752,6 +752,9 @@ cdef class Tick(SingleConstructorOffset): | |||
| "Tick offset with `normalize=True` are not allowed." | |||
| ) | |||
|
|
|||
| def __hash__(self) -> int: | |||
jorisvandenbossche
requested changes
Oct 21, 2020
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
thanks @phofl nice |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 22, 2020
… be no longer hashable
jorisvandenbossche
pushed a commit
that referenced
this pull request
Oct 22, 2020
…ger hashable (#37326) Co-authored-by: patrick <61934744+phofl@users.noreply.github.com>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff