CLN: make PeriodArray signature match DTA/TDA #37289
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Oct 20, 2020
jreback
added
API - Consistency
jreback
reviewed
Oct 20, 2020
| @@ -148,7 +148,7 @@ class PeriodArray(PeriodMixin, dtl.DatelikeOps): | |||
| # -------------------------------------------------------------------- | |||
| # Constructors | |||
|
|
|||
| def __init__(self, values, freq=None, dtype=None, copy=False): | |||
| def __init__(self, values, dtype=None, freq=None, copy=False): | |||
There was a problem hiding this comment.
we should consider making optional values keyword only generally (let's create an issue / discussion point)
jreback
approved these changes
Oct 20, 2020
|
lgtm merge on green-ish |
jreback
approved these changes
Oct 20, 2020
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff